QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(chart-data-api): ignore unknown fields on QueryObject (#12118)

Browse Source
This commit is contained in:
Ville Brofeldt
2020-12-18 14:32:55 +02:00
committed by GitHub
parent 6621557af2
commit 1a5f61b133
2 changed files with 25 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/query_context_tests.py
View File

@@ -198,7 +198,7 @@ class TestQueryContext(SupersetTestCase):
def test_sql_injection_via_columns(self):
"""
Ensure that calling invalid columns names in columns are caught
Ensure that calling invalid column names in columns are caught
"""
self.login(username="admin")
table_name = "birth_names"
@@ -213,7 +213,7 @@ class TestQueryContext(SupersetTestCase):
def test_sql_injection_via_metrics(self):
"""
Ensure that calling invalid columns names in filters are caught
Ensure that calling invalid column names in filters are caught
"""
self.login(username="admin")
table_name = "birth_names"
@@ -266,3 +266,22 @@ class TestQueryContext(SupersetTestCase):
self.assertEqual(len(response), 2)
self.assertEqual(response["language"], "sql")
self.assertIn("SELECT", response["query"])
def test_query_object_unknown_fields(self):
"""
Ensure that query objects with unknown fields don't raise an Exception and
have an identical cache key as one without the unknown field
"""
self.maxDiff = None
self.login(username="admin")
table_name = "birth_names"
table = self.get_table_by_name(table_name)
payload = get_query_context(table.name, table.id, table.type)
query_context = ChartDataQueryContextSchema().load(payload)
responses = query_context.get_payload()
orig_cache_key = responses["queries"][0]["cache_key"]
payload["queries"][0]["foo"] = "bar"
query_context = ChartDataQueryContextSchema().load(payload)
responses = query_context.get_payload()
new_cache_key = responses["queries"][0]["cache_key"]
self.assertEqual(orig_cache_key, new_cache_key)