QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 08:34:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(explore): Enhance Dataset and Control panel Collapse components (#12218)

Browse Source
This commit is contained in:
Geido
2021-01-26 00:05:19 +01:00
committed by GitHub
parent 0fed1e04ef
commit 1b2611c211
10 changed files with 107 additions and 240 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
superset-frontend/spec/javascripts/explore/components/ControlPanelSection_spec.jsx
View File

@@ -1,69 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import { shallow } from 'enzyme';
import { Panel } from 'react-bootstrap';
import { InfoTooltipWithTrigger } from '@superset-ui/chart-controls';
import ControlPanelSection from 'src/explore/components/ControlPanelSection';
const defaultProps = {
children: <div>a child element</div>,
};
const optionalProps = {
label: 'my label',
description: 'my description',
tooltip: 'my tooltip',
};
describe('ControlPanelSection', () => {
let wrapper;
let props;
it('is a valid element', () => {
expect(
React.isValidElement(<ControlPanelSection {...defaultProps} />),
).toBe(true);
});
it('renders a Panel component', () => {
wrapper = shallow(<ControlPanelSection {...defaultProps} />);
expect(wrapper.find(Panel)).toExist();
});
describe('with optional props', () => {
beforeEach(() => {
props = Object.assign(defaultProps, optionalProps);
wrapper = shallow(<ControlPanelSection {...props} />);
});
it('renders a label if present', () => {
expect(
wrapper
.find('[data-test="clickable-control-panel-section-title"]')
.text(),
).toContain('my label');
});
it('renders a InfoTooltipWithTrigger if label and tooltip is present', () => {
expect(
wrapper.find(Panel).dive().find(InfoTooltipWithTrigger),
).toHaveLength(1);
});
});
});

4
superset-frontend/spec/javascripts/explore/components/ControlPanelsContainer_spec.jsx
View File

@@ -22,7 +22,7 @@ import { getChartControlPanelRegistry, t } from '@superset-ui/core';
import { defaultControls } from 'src/explore/store';
import { getFormDataFromControls } from 'src/explore/controlUtils';
import { ControlPanelsContainer } from 'src/explore/components/ControlPanelsContainer';
import ControlPanelSection from 'src/explore/components/ControlPanelSection';
import Collapse from 'src/common/components/Collapse';
describe('ControlPanelsContainer', () => {
let wrapper;
@@ -91,6 +91,6 @@ describe('ControlPanelsContainer', () => {
it('renders ControlPanelSections', () => {
wrapper = shallow(<ControlPanelsContainer {...getDefaultProps()} />);
expect(wrapper.find(ControlPanelSection)).toHaveLength(5);
expect(wrapper.find(Collapse.Panel)).toHaveLength(5);
});
});