QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-22 09:35:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sqllab): flaky json explore modal due to shallow equality checks for extra data (#29978)

Browse Source
This commit is contained in:
JUST.in DO IT
2024-08-22 07:28:08 +09:00
committed by GitHub
parent 7650c47e72
commit 1ca5947a7d
2 changed files with 42 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
superset-frontend/src/SqlLab/reducers/sqlLab.test.js
View File

@@ -449,6 +449,35 @@ describe('sqlLabReducer', () => {
expect(newState.queries.abcd.endDttm).toBe(Number(endDttmInStr));
expect(newState.queriesLastUpdate).toBe(CHANGED_ON_TIMESTAMP);
});
it('should skip refreshing queries when polling contains existing results', () => {
const completedQuery = {
...query,
extra: {
columns: [],
progress: null,
},
};
newState = sqlLabReducer(
{
...newState,
queries: { abcd: query, def: completedQuery },
},
actions.refreshQueries({
abcd: {
...query,
},
def: {
...completedQuery,
extra: {
columns: [],
progress: null,
},
},
}),
);
expect(newState.queries.abcd).toBe(query);
expect(newState.queries.def).toBe(completedQuery);
});
it('should refresh queries when polling returns empty', () => {
newState = sqlLabReducer(newState, actions.refreshQueries({}));
});