QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 00:54:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix running query on every change in chart controls (#12361)

Browse Source
This commit is contained in:
Kamil Gabryjelski
2021-01-08 21:56:45 +01:00
committed by GitHub
parent 7c8ead85c1
commit 1d2789944c
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/src/explore/components/ExploreViewContainer.jsx
View File

@@ -265,7 +265,6 @@ function ExploreViewContainer(props) {
}
}, [isDynamicPluginLoading]);
// effect to run when controls change
useEffect(() => {
const hasError = Object.values(props.controls).some(
control =>
@@ -274,7 +273,10 @@ function ExploreViewContainer(props) {
if (!hasError) {
props.actions.triggerQuery(true, props.chart.id);
}
}, []);
// effect to run when controls change
useEffect(() => {
if (previousControls) {
if (props.controls.viz_type.value !== previousControls.viz_type.value) {
props.actions.resetControls();