QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-08-12 11:11:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(mcp): defer chart preview command imports (#40164)

Browse Source
This commit is contained in:
Richard Fogaca Nienkotter
2026-05-15 12:15:33 -03:00
committed by GitHub
parent 59b5f69627
commit 1e2d0b5f5b
3 changed files with 46 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit_tests/mcp_service/chart/tool/test_get_chart_data.py
+4 -4
View File
@@ -1007,12 +1007,12 @@ class TestChartDataCommandValidation:
mock_dataset = MagicMock()
mock_dataset.id = 10
# ChartDataCommand is module-level import in preview_utils;
# db and QueryContextFactory are local imports inside the function.
# ChartDataCommand, db, and QueryContextFactory are local imports inside
# the function so preview_utils stays safe to import before app setup.
with (
patch("superset.extensions.db") as mock_db,
patch(
"superset.mcp_service.chart.preview_utils.ChartDataCommand",
"superset.commands.chart.data.get_data_command.ChartDataCommand",
return_value=mock_command,
),
patch(
@@ -1061,7 +1061,7 @@ class TestChartDataCommandValidation:
with (
patch("superset.extensions.db") as mock_db,
patch(
"superset.mcp_service.chart.preview_utils.ChartDataCommand",
"superset.commands.chart.data.get_data_command.ChartDataCommand",
return_value=mock_command,
),
patch(