QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-23 18:14:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: better handle datasource exceptions (#13578)

Browse Source 
* fix: handle datasource injected security exception

* add tests

* fix error text on create update dbs

* fix lint

* revert create update message

* fix test

* add sqlalchemy exceptions
This commit is contained in:
Daniel Vaz Gaspar
2021-03-15 22:46:51 +00:00
committed by GitHub
parent 868e063b03
commit 1e88408418
4 changed files with 76 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset/databases/commands/update.py
View File

@@ -54,7 +54,7 @@ class UpdateDatabaseCommand(BaseCommand):
# TODO Improve this simplistic implementation for catching DB conn fails
try:
schemas = database.get_all_schema_names()
except Exception:
except Exception as ex:
db.session.rollback()
raise DatabaseConnectionFailedError()
for schema in schemas: