QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

including auto generated avg metrics in druid (#4718)

Browse Source
This commit is contained in:
Gabe Lyons
2018-04-02 16:08:25 -07:00
committed by Grace Guo
parent e0f541f486
commit 1ef856e57a
2 changed files with 39 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
superset/assets/spec/javascripts/explore/components/MetricsControl_spec.jsx
View File

@@ -24,6 +24,7 @@ const defaultProps = {
{ metric_name: 'sum__value', expression: 'SUM(energy_usage.value)' },
{ metric_name: 'avg__value', expression: 'AVG(energy_usage.value)' },
],
datasourceType: 'sqla',
};
function setup(overrides) {
@@ -188,7 +189,7 @@ describe('MetricsControl', () => {
describe('option filter', () => {
it('includes user defined metrics', () => {
const { wrapper } = setup();
const { wrapper } = setup({ datasourceType: 'druid' });
expect(!!wrapper.instance().selectFilterOption(
{
@@ -200,6 +201,19 @@ describe('MetricsControl', () => {
)).to.be.true;
});
it('includes auto generated avg metrics for druid', () => {
const { wrapper } = setup({ datasourceType: 'druid' });
expect(!!wrapper.instance().selectFilterOption(
{
metric_name: 'a_metric',
optionName: 'a_metric',
expression: 'AVG(metric)',
},
'a',
)).to.be.true;
});
it('includes columns and aggregates', () => {
const { wrapper } = setup();
@@ -214,6 +228,19 @@ describe('MetricsControl', () => {
)).to.be.true;
});
it('excludes auto generated avg metrics for sqla', () => {
const { wrapper } = setup();
expect(!!wrapper.instance().selectFilterOption(
{
metric_name: 'a_metric',
optionName: 'a_metric',
expression: 'AVG(metric)',
},
'a',
)).to.be.false;
});
it('excludes auto generated metrics', () => {
const { wrapper } = setup();