QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 17:14:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

[explore] fix missing CacheLabel (#4326)

Browse Source 
Also adding a basic unit test.
This commit is contained in:
Maxime Beauchemin
2018-02-02 10:28:38 -08:00
committed by Grace Guo
parent 75a2b4f610
commit 1f8fccc0f9
2 changed files with 48 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
superset/assets/javascripts/explore/components/ExploreChartHeader.jsx
View File

@@ -74,7 +74,7 @@ class ExploreChartHeader extends React.PureComponent {
json_endpoint: getExploreUrl(formData, 'json'),
standalone_endpoint: getExploreUrl(formData, 'standalone'),
};
const chartSucceeded = ['success', 'rendered'].indexOf(this.props.chart.chartStatus) > 0;
return (
<div
id="slice-header"
@@ -115,21 +115,16 @@ class ExploreChartHeader extends React.PureComponent {
/>
}
<div className="pull-right">
{this.props.chart.chartStatus === 'success' && queryResponse &&
{chartSucceeded && queryResponse &&
<RowCountLabel
rowcount={queryResponse.rowcount}
limit={formData.row_limit}
/>
}
{this.props.chart.chartStatus === 'success' &&
queryResponse &&
queryResponse.is_cached &&
<CachedLabel
onClick={this.runQuery.bind(this)}
cachedTimestamp={queryResponse.cached_dttm}
/>
}
/>}
{chartSucceeded && queryResponse && queryResponse.is_cached &&
<CachedLabel
onClick={this.runQuery.bind(this)}
cachedTimestamp={queryResponse.cached_dttm}
/>}
<Timer
startTime={this.props.chart.chartUpdateStartTime}
endTime={this.props.chart.chartUpdateEndTime}