mirror of
https://github.com/apache/superset.git
synced 2026-04-10 20:06:13 +00:00
fix: select star (#33763)
This commit is contained in:
@@ -22,10 +22,12 @@ import pytest
|
||||
from pytest_mock import MockerFixture
|
||||
from sqlalchemy import column, types
|
||||
from sqlalchemy.dialects.postgresql import DOUBLE_PRECISION, ENUM, JSON
|
||||
from sqlalchemy.engine.interfaces import Dialect
|
||||
from sqlalchemy.engine.url import make_url
|
||||
|
||||
from superset.db_engine_specs.postgres import PostgresEngineSpec as spec # noqa: N813
|
||||
from superset.exceptions import SupersetSecurityException
|
||||
from superset.sql.parse import Table
|
||||
from superset.utils.core import GenericDataType
|
||||
from tests.unit_tests.db_engine_specs.utils import (
|
||||
assert_column_spec,
|
||||
@@ -243,3 +245,38 @@ def test_timegrain_expressions(time_grain: str, expected_result: str) -> None:
|
||||
spec.get_timestamp_expr(col=column("col"), pdf=None, time_grain=time_grain)
|
||||
)
|
||||
assert actual == expected_result
|
||||
|
||||
|
||||
def test_select_star(mocker: MockerFixture) -> None:
|
||||
"""
|
||||
Test the ``select_star`` method.
|
||||
"""
|
||||
database = mocker.MagicMock()
|
||||
engine = mocker.MagicMock()
|
||||
|
||||
def quote_table(table: Table, dialect: Dialect) -> str:
|
||||
return ".".join(
|
||||
part for part in (table.catalog, table.schema, table.table) if part
|
||||
)
|
||||
|
||||
mocker.patch.object(spec, "quote_table", quote_table)
|
||||
|
||||
spec.select_star(
|
||||
database=database,
|
||||
table=Table("my_table", "my_schema", "my_catalog"),
|
||||
engine=engine,
|
||||
limit=100,
|
||||
show_cols=False,
|
||||
indent=True,
|
||||
latest_partition=False,
|
||||
cols=None,
|
||||
)
|
||||
|
||||
query = database.compile_sqla_query.mock_calls[0][1][0]
|
||||
assert (
|
||||
str(query)
|
||||
== """
|
||||
SELECT * \nFROM my_schema.my_table
|
||||
LIMIT :param_1
|
||||
""".strip()
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user