From 21f77f37175a6b069a1f2e8d0742ee85fb910eae Mon Sep 17 00:00:00 2001 From: "Michael S. Molina" <70410625+michael-s-molina@users.noreply.github.com> Date: Wed, 23 Jul 2025 11:33:06 -0300 Subject: [PATCH] fix: Bulk select is not respecting the TAGGING_SYSTEM feature flag (#34282) (cherry picked from commit 11324607d06765364016bf4fcf13360ca462a378) --- superset-frontend/src/pages/ChartList/index.tsx | 3 ++- superset-frontend/src/pages/DashboardList/index.tsx | 3 ++- superset-frontend/src/pages/SavedQueryList/index.tsx | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/superset-frontend/src/pages/ChartList/index.tsx b/superset-frontend/src/pages/ChartList/index.tsx index 031722ab22c..7dbb9b77fac 100644 --- a/superset-frontend/src/pages/ChartList/index.tsx +++ b/superset-frontend/src/pages/ChartList/index.tsx @@ -801,6 +801,7 @@ function ChartList(props: ChartListProps) { onConfirm={handleBulkChartDelete} > {confirmDelete => { + const enableBulkTag = isFeatureEnabled(FeatureFlag.TaggingSystem); const bulkActions: ListViewProps['bulkActions'] = []; if (canDelete) { bulkActions.push({ @@ -835,7 +836,7 @@ function ChartList(props: ChartListProps) { loading={loading} pageSize={PAGE_SIZE} renderCard={renderCard} - enableBulkTag + enableBulkTag={enableBulkTag} bulkTagResourceName="chart" addSuccessToast={addSuccessToast} addDangerToast={addDangerToast} diff --git a/superset-frontend/src/pages/DashboardList/index.tsx b/superset-frontend/src/pages/DashboardList/index.tsx index 3e63bd4b911..5ca07dbe4ea 100644 --- a/superset-frontend/src/pages/DashboardList/index.tsx +++ b/superset-frontend/src/pages/DashboardList/index.tsx @@ -714,6 +714,7 @@ function DashboardList(props: DashboardListProps) { onConfirm={handleBulkDashboardDelete} > {confirmDelete => { + const enableBulkTag = isFeatureEnabled(FeatureFlag.TaggingSystem); const bulkActions: ListViewProps['bulkActions'] = []; if (canDelete) { bulkActions.push({ @@ -793,7 +794,7 @@ function DashboardList(props: DashboardListProps) { ? 'card' : 'table' } - enableBulkTag + enableBulkTag={enableBulkTag} bulkTagResourceName="dashboard" /> diff --git a/superset-frontend/src/pages/SavedQueryList/index.tsx b/superset-frontend/src/pages/SavedQueryList/index.tsx index 052815f6356..9a5fd63e4c8 100644 --- a/superset-frontend/src/pages/SavedQueryList/index.tsx +++ b/superset-frontend/src/pages/SavedQueryList/index.tsx @@ -583,6 +583,7 @@ function SavedQueryList({ onConfirm={handleBulkQueryDelete} > {confirmDelete => { + const enableBulkTag = isFeatureEnabled(FeatureFlag.TaggingSystem); const bulkActions: ListViewProps['bulkActions'] = []; if (canDelete) { bulkActions.push({ @@ -617,7 +618,7 @@ function SavedQueryList({ bulkSelectEnabled={bulkSelectEnabled} disableBulkSelect={toggleBulkSelect} highlightRowId={savedQueryCurrentlyPreviewing?.id} - enableBulkTag + enableBulkTag={enableBulkTag} bulkTagResourceName="query" refreshData={refreshData} />