QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 16:44:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(theming): add base theme config (#35220)

Browse Source
This commit is contained in:
Gabriel Torres Ruiz
2025-09-30 14:01:31 -04:00
committed by GitHub
parent ef78d2af06
commit 220480b627
14 changed files with 1700 additions and 455 deletions
Download Patch File Download Diff File Expand all files Collapse all files

140
tests/unit_tests/daos/test_theme_dao.py
View File

@@ -45,8 +45,7 @@ class TestThemeDAO:
assert result == mock_theme
@patch("superset.daos.theme.db.session")
@patch("superset.daos.theme.logger")
def test_find_system_default_multiple(self, mock_logger, mock_session):
def test_find_system_default_multiple(self, mock_session):
"""Test finding system default theme when multiple exist"""
# Create mock themes
mock_theme1 = MagicMock(spec=Theme)
@@ -54,69 +53,33 @@ class TestThemeDAO:
mock_theme2 = MagicMock(spec=Theme)
mock_theme2.is_system_default = True
# Create mock fallback theme
mock_fallback = MagicMock(spec=Theme)
mock_fallback.is_system = True
mock_fallback.theme_name = "THEME_DEFAULT"
# Mock the query chains - need separate mocks for each query call
mock_query1 = MagicMock()
mock_query2 = MagicMock()
mock_session.query.side_effect = [mock_query1, mock_query2]
# First query returns multiple themes
mock_filter1 = MagicMock()
mock_query1.filter.return_value = mock_filter1
mock_filter1.all.return_value = [mock_theme1, mock_theme2]
# Second query returns fallback theme
mock_filter2 = MagicMock()
mock_query2.filter.return_value = mock_filter2
mock_filter2.first.return_value = mock_fallback
# Mock the query chain
mock_query = MagicMock()
mock_session.query.return_value = mock_query
mock_filter = MagicMock()
mock_query.filter.return_value = mock_filter
mock_filter.all.return_value = [mock_theme1, mock_theme2]
# Call the method
result = ThemeDAO.find_system_default()
# Verify warning was logged with lazy logging format
mock_logger.warning.assert_called_once()
call_args = mock_logger.warning.call_args
assert (
call_args[0][0]
== "Multiple system default themes found (%s), falling back to config theme"
)
assert call_args[0][1] == 2
# Verify the result is the fallback theme
assert result == mock_fallback
assert result is None
@patch("superset.daos.theme.db.session")
def test_find_system_default_none(self, mock_session):
"""Test finding system default theme when none exist"""
# Create mock fallback theme
mock_fallback = MagicMock(spec=Theme)
mock_fallback.is_system = True
mock_fallback.theme_name = "THEME_DEFAULT"
# Mock the query chains - need separate mocks for each query call
mock_query1 = MagicMock()
mock_query2 = MagicMock()
mock_session.query.side_effect = [mock_query1, mock_query2]
# First query returns no themes
mock_filter1 = MagicMock()
mock_query1.filter.return_value = mock_filter1
mock_filter1.all.return_value = []
# Second query returns fallback theme
mock_filter2 = MagicMock()
mock_query2.filter.return_value = mock_filter2
mock_filter2.first.return_value = mock_fallback
# Mock the query chain
mock_query = MagicMock()
mock_session.query.return_value = mock_query
mock_filter = MagicMock()
mock_query.filter.return_value = mock_filter
mock_filter.all.return_value = []
# Call the method
result = ThemeDAO.find_system_default()
# Verify the result is the fallback theme
assert result == mock_fallback
# Verify the result is None (no fallback)
assert result is None
@patch("superset.daos.theme.db.session")
def test_find_system_dark_single(self, mock_session):
@@ -139,8 +102,7 @@ class TestThemeDAO:
assert result == mock_theme
@patch("superset.daos.theme.db.session")
@patch("superset.daos.theme.logger")
def test_find_system_dark_multiple(self, mock_logger, mock_session):
def test_find_system_dark_multiple(self, mock_session):
"""Test finding system dark theme when multiple exist"""
# Create mock themes
mock_theme1 = MagicMock(spec=Theme)
@@ -148,69 +110,33 @@ class TestThemeDAO:
mock_theme2 = MagicMock(spec=Theme)
mock_theme2.is_system_dark = True
# Create mock fallback theme
mock_fallback = MagicMock(spec=Theme)
mock_fallback.is_system = True
mock_fallback.theme_name = "THEME_DARK"
# Mock the query chains - need separate mocks for each query call
mock_query1 = MagicMock()
mock_query2 = MagicMock()
mock_session.query.side_effect = [mock_query1, mock_query2]
# First query returns multiple themes
mock_filter1 = MagicMock()
mock_query1.filter.return_value = mock_filter1
mock_filter1.all.return_value = [mock_theme1, mock_theme2]
# Second query returns fallback theme
mock_filter2 = MagicMock()
mock_query2.filter.return_value = mock_filter2
mock_filter2.first.return_value = mock_fallback
# Mock the query chain
mock_query = MagicMock()
mock_session.query.return_value = mock_query
mock_filter = MagicMock()
mock_query.filter.return_value = mock_filter
mock_filter.all.return_value = [mock_theme1, mock_theme2]
# Call the method
result = ThemeDAO.find_system_dark()
# Verify warning was logged with lazy logging format
mock_logger.warning.assert_called_once()
call_args = mock_logger.warning.call_args
assert (
call_args[0][0]
== "Multiple system dark themes found (%s), falling back to config theme"
)
assert call_args[0][1] == 2
# Verify the result is the fallback theme
assert result == mock_fallback
assert result is None
@patch("superset.daos.theme.db.session")
def test_find_system_dark_none_with_fallback(self, mock_session):
"""Test finding system dark theme when none exist but fallback does"""
# Create mock fallback theme
mock_fallback = MagicMock(spec=Theme)
mock_fallback.is_system = True
mock_fallback.theme_name = "THEME_DARK"
# Mock the query chains - need separate mocks for each query call
mock_query1 = MagicMock()
mock_query2 = MagicMock()
mock_session.query.side_effect = [mock_query1, mock_query2]
# First query returns no themes
mock_filter1 = MagicMock()
mock_query1.filter.return_value = mock_filter1
mock_filter1.all.return_value = []
# Second query returns fallback theme
mock_filter2 = MagicMock()
mock_query2.filter.return_value = mock_filter2
mock_filter2.first.return_value = mock_fallback
"""Test finding system dark theme when none exist"""
# Mock the query chain
mock_query = MagicMock()
mock_session.query.return_value = mock_query
mock_filter = MagicMock()
mock_query.filter.return_value = mock_filter
mock_filter.all.return_value = []
# Call the method
result = ThemeDAO.find_system_dark()
# Verify the result is the fallback theme
assert result == mock_fallback
# Verify the result is None (no fallback)
assert result is None
@patch("superset.daos.theme.db.session")
def test_find_system_dark_none_without_fallback(self, mock_session):