QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-09-01 21:11:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ux): use title case for button labels (#40048)

Browse Source 
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
This commit is contained in:
Kasia
2026-08-20 20:14:33 -07:00
committed by GitHub
co-authored by Claude Sonnet 4.6 Evan Rusackas
parent 27ea5de44a
commit 22396d504a
7 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx
+4 -4
View File
@@ -150,7 +150,7 @@ const waitForRender = (props?: any) =>
test('renders with default props', async () => {
await waitForRender();
expect(screen.getByRole('button', { name: 'Apply' })).toBeDisabled();
expect(screen.getByRole('button', { name: 'OK' })).toBeDisabled();
expect(screen.getByRole('button', { name: 'Confirm' })).toBeDisabled();
expect(screen.getByRole('button', { name: 'Cancel' })).toBeEnabled();
});
@@ -188,7 +188,7 @@ test('enables apply and ok buttons', async () => {
await waitFor(() => {
expect(screen.getByRole('button', { name: 'Apply' })).toBeEnabled();
expect(screen.getByRole('button', { name: 'OK' })).toBeEnabled();
expect(screen.getByRole('button', { name: 'Confirm' })).toBeEnabled();
});
});
@@ -203,7 +203,7 @@ test('triggers addAnnotationLayer and close when ok button is clicked', async ()
const addAnnotationLayer = jest.fn();
const close = jest.fn();
await waitForRender({ name: 'Test', value: '2x', addAnnotationLayer, close });
userEvent.click(screen.getByRole('button', { name: 'OK' }));
userEvent.click(screen.getByRole('button', { name: 'Confirm' }));
expect(addAnnotationLayer).toHaveBeenCalled();
expect(close).toHaveBeenCalled();
});
@@ -724,7 +724,7 @@ test('Disable apply button if formula is incorrect', async () => {
const formulaInput = screen.getByRole('textbox', { name: 'Formula' });
const applyButton = screen.getByRole('button', { name: 'Apply' });
const okButton = screen.getByRole('button', { name: 'OK' });
const okButton = screen.getByRole('button', { name: 'Confirm' });
userEvent.type(formulaInput, 'x+1');
expect(formulaInput).toHaveValue('x+1');