QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(explore): Prevent shared controls from checking feature flags outside React render (#21315)

Browse Source
This commit is contained in:
Cody Leff
2022-09-14 14:41:47 -04:00
committed by GitHub
parent 59ca7861c0
commit 2285ebe72e
21 changed files with 285 additions and 435 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/columns.tsx
View File

@@ -49,7 +49,7 @@ const allColumns: typeof sharedControls.groupby = {
options: datasource?.columns || [],
queryMode: getQueryMode(controls),
externalValidationErrors:
isRawMode({ controls }) && ensureIsArray(controlState.value).length === 0
isRawMode({ controls }) && ensureIsArray(controlState?.value).length === 0
? [t('must have a value')]
: [],
}),
@@ -74,7 +74,7 @@ const dndAllColumns: typeof sharedControls.groupby = {
}
newState.queryMode = getQueryMode(controls);
newState.externalValidationErrors =
isRawMode({ controls }) && ensureIsArray(controlState.value).length === 0
isRawMode({ controls }) && ensureIsArray(controlState?.value).length === 0
? [t('must have a value')]
: [];
return newState;

2
superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/metrics.tsx
View File

@@ -46,7 +46,7 @@ const percentMetrics: typeof sharedControls.metrics = {
externalValidationErrors: validateAggControlValues(controls, [
controls.groupby?.value,
controls.metrics?.value,
controlState.value,
controlState?.value,
]),
}),
rerender: ['groupby', 'metrics'],