QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Gauge): clearing previously set min and max values in a gauge chart sets the data labels to 0 (#36425)

Browse Source 
Co-authored-by: Diego Pucci <diegopucci.me@gmail.com>
This commit is contained in:
Enzo Martellucci
2025-12-05 18:16:43 +01:00
committed by GitHub
parent 8c603a6f8b
commit 236e000398
2 changed files with 419 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
superset-frontend/plugins/plugin-chart-echarts/src/Gauge/transformProps.ts
View File

@@ -222,8 +222,20 @@ export default function transformProps(
const { setDataMask = () => {}, onContextMenu } = hooks;
const min = minVal ?? calculateMin(transformedData);
const max = maxVal ?? calculateMax(transformedData);
const isValidNumber = (
val: number | null | undefined | string,
): val is number => {
if (val == null || val === '') return false;
const num = typeof val === 'string' ? Number(val) : val;
return !Number.isNaN(num) && Number.isFinite(num);
};
const min = isValidNumber(minVal)
? Number(minVal)
: calculateMin(transformedData);
const max = isValidNumber(maxVal)
? Number(maxVal)
: calculateMax(transformedData);
const axisLabels = range(min, max, (max - min) / splitNumber);
const axisLabelLength = Math.max(
...axisLabels.map(label => numberFormatter(label).length).concat([1]),