From 24d76b42495cdf3bf5a64b5f7eb60d7eaf64989f Mon Sep 17 00:00:00 2001 From: Nitish Agarwal <1592163+nitishagar@users.noreply.github.com> Date: Tue, 12 May 2026 08:54:25 +0530 Subject: [PATCH] fix(sunburst): remove label text outline in dark theme (#39774) --- .../src/Sunburst/transformProps.ts | 2 - .../test/Sunburst/transformProps.test.ts | 53 +++++++++++++++++++ 2 files changed, 53 insertions(+), 2 deletions(-) create mode 100644 superset-frontend/plugins/plugin-chart-echarts/test/Sunburst/transformProps.test.ts diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts index 9104518625d..8ffde2656ac 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts @@ -285,8 +285,6 @@ export default function transformProps( } const labelProps = { color: theme.colorText, - textBorderColor: theme.colorBgBase, - textBorderWidth: 1, }; const traverse = ( treeNodes: TreeNode[], diff --git a/superset-frontend/plugins/plugin-chart-echarts/test/Sunburst/transformProps.test.ts b/superset-frontend/plugins/plugin-chart-echarts/test/Sunburst/transformProps.test.ts new file mode 100644 index 00000000000..043b0395a64 --- /dev/null +++ b/superset-frontend/plugins/plugin-chart-echarts/test/Sunburst/transformProps.test.ts @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { ChartProps } from '@superset-ui/core'; +import { supersetTheme } from '@apache-superset/core/theme'; +import { EchartsSunburstChartProps } from '../../src/Sunburst/types'; +import transformProps from '../../src/Sunburst/transformProps'; + +const formData = { + colorScheme: 'bnbColors', + datasource: '3__table', + groupby: ['category'], + metric: 'sum__value', +}; + +const chartProps = new ChartProps({ + formData, + width: 800, + height: 600, + queriesData: [ + { + data: [ + { category: 'A', sum__value: 10 }, + { category: 'B', sum__value: 20 }, + ], + }, + ], + theme: supersetTheme, +}); + +test('series label has no textBorderColor or textBorderWidth', () => { + const { echartOptions } = transformProps( + chartProps as EchartsSunburstChartProps, + ); + const series = (echartOptions as any).series[0]; + expect(series.label).not.toHaveProperty('textBorderColor'); + expect(series.label).not.toHaveProperty('textBorderWidth'); +});