QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dashboard] notify instead of modal onSave (#2941)

Browse Source 
* [dashboard] notify instead of modal onSave

* Addressing comments
This commit is contained in:
Maxime Beauchemin
2017-06-12 21:04:46 -07:00
committed by GitHub
parent 987cb9978d
commit 24e3c7f89a
2 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
superset/assets/javascripts/dashboard/Dashboard.jsx
View File

@@ -7,6 +7,7 @@ import moment from 'moment';
import GridLayout from './components/GridLayout';
import Header from './components/Header';
import { appSetup } from '../common';
import AlertsWrapper from '../components/AlertsWrapper';
import '../../stylesheets/dashboard.css';
@@ -60,7 +61,10 @@ function renderAlert() {
function initDashboardView(dashboard) {
render(
<Header dashboard={dashboard} />,
<div>
<AlertsWrapper />
<Header dashboard={dashboard} />
</div>,
document.getElementById('dashboard-header'),
);
// eslint-disable-next-line no-param-reassign
@@ -332,7 +336,7 @@ export function dashboardContainer(dashboard, datasources, userid) {
const errorMsg = getAjaxErrorMsg(error);
utils.showModal({
title: 'Error',
body: 'Sorry, there was an error adding slices to this dashboard: </ br>' + errorMsg,
body: 'Sorry, there was an error adding slices to this dashboard: ' + errorMsg,
});
},
});