From 27aeac6859da39fea0aebc4920c1fce08fde61e5 Mon Sep 17 00:00:00 2001 From: vera-liu Date: Tue, 31 Jan 2017 17:25:06 -0800 Subject: [PATCH] Remove fetch results button for async queries (#2084) --- .../SqlLab/components/ResultSet.jsx | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/superset/assets/javascripts/SqlLab/components/ResultSet.jsx b/superset/assets/javascripts/SqlLab/components/ResultSet.jsx index 13c41969303..69c9b6fc435 100644 --- a/superset/assets/javascripts/SqlLab/components/ResultSet.jsx +++ b/superset/assets/javascripts/SqlLab/components/ResultSet.jsx @@ -46,6 +46,10 @@ class ResultSet extends React.PureComponent { this.clearQueryResults(nextProps.query) ); } + if (nextProps.query.resultsKey + && nextProps.query.resultsKey !== this.props.query.resultsKey) { + this.fetchResults(nextProps.query); + } } getControls() { if (this.props.search || this.props.visualize || this.props.csv) { @@ -197,20 +201,6 @@ class ResultSet extends React.PureComponent { ); - } else if (query.resultsKey) { - if (results && data && data.length === 0) { - // if fetched result contains zero rows of data - return The asynchronous query returned no data; - } - return ( -
- This query was run asynchronously   - - -
- ); } } if (query.cached) {