QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-09 01:46:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(mcp): warn when execute_sql template_params used with templating disabled (#39858)

Browse Source
This commit is contained in:
Amin Ghadersohi
2026-05-04 12:14:44 -04:00
committed by GitHub
parent 6205afbaa0
commit 28239c18d4
3 changed files with 124 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
superset/mcp_service/sql_lab/tool/execute_sql.py
View File

@@ -86,7 +86,7 @@ async def execute_sql(request: ExecuteSqlRequest, ctx: Context) -> ExecuteSqlRes
try:
# Import inside function to avoid initialization issues
from superset import db, security_manager
from superset import db, is_feature_enabled, security_manager
from superset.models.core import Database
# 1. Get database and check access
@@ -134,6 +134,22 @@ async def execute_sql(request: ExecuteSqlRequest, ctx: Context) -> ExecuteSqlRes
with event_logger.log_context(action="mcp.execute_sql.response_conversion"):
response = _convert_to_response(result)
# Surface a warning when template_params is supplied but Jinja
# rendering is disabled — otherwise the params are silently dropped.
if request.template_params and not is_feature_enabled(
"ENABLE_TEMPLATE_PROCESSING"
):
response.template_warning = (
"template_params was supplied but Jinja2 rendering is "
"disabled on this Superset instance "
"(ENABLE_TEMPLATE_PROCESSING feature flag is off). "
"Template variables in the SQL were NOT substituted; "
"the query was executed with literal '{{ var }}' placeholders."
)
await ctx.warning(
"template_params supplied but ENABLE_TEMPLATE_PROCESSING is off"
)
# Log successful execution
if response.success:
await ctx.info(