QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Deprecate database attribute allow_run_sync (#4961)

Browse Source 
* Deprecate database attribute allow_run_sync

There's really 2 modes of operations in SQL Lab, sync or async
though currently there are 2 boolean flags: allow_run_sync and
allow_run_async, leading to 4 potential combinations, only 2 of which
actually makes sense.

The original vision is that we'd expose the choice to users and they
would decide which `Run` or `Run Async` button to hit.
Later on we decided to have a
single button and for each database to be either sync or async.

This PR cleans up allow_run_sync by removing references to it.

* Fix build

* Add db migration

* using batch_op
This commit is contained in:
Maxime Beauchemin
2018-11-27 21:08:44 -08:00
committed by GitHub
parent 529cb5cab1
commit 2931baa294
8 changed files with 80 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset/assets/spec/javascripts/sqllab/fixtures.js
View File

@@ -292,7 +292,6 @@ export const databases = {
allow_ctas: true,
allow_dml: true,
allow_run_async: false,
allow_run_sync: true,
database_name: 'main',
expose_in_sqllab: true,
force_ctas_schema: '',
@@ -302,7 +301,6 @@ export const databases = {
allow_ctas: true,
allow_dml: false,
allow_run_async: true,
allow_run_sync: true,
database_name: 'Presto - Gold',
expose_in_sqllab: true,
force_ctas_schema: 'tmp',