QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

[druid] fixing the having clause in the explore view (#2648)

Browse Source 
* [druid] fixing the having clause in the explore view

* Backend

* Lint

* Fixing tests
This commit is contained in:
Maxime Beauchemin
2017-04-24 16:31:16 -07:00
committed by GitHub
parent f10ee13901
commit 29780821e8
5 changed files with 37 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
superset/assets/spec/javascripts/explorev2/components/Filter_spec.jsx
View File

@@ -22,6 +22,10 @@ const defaultProps = {
type: 'qtable',
filter_select: false,
filterable_cols: ['col1', 'col2'],
metrics_combo: [
['m1', 'v1'],
['m2', 'v2'],
],
},
};
@@ -46,7 +50,7 @@ describe('Filter', () => {
});
it('renders five op choices for table datasource', () => {
const props = defaultProps;
const props = Object.assign({}, defaultProps);
props.datasource = {
id: 1,
type: 'druid',
@@ -58,10 +62,10 @@ describe('Filter', () => {
});
it('renders six op choices for having filter', () => {
const props = defaultProps;
const props = Object.assign({}, defaultProps);
props.having = true;
const havingWrapper = shallow(<Filter {...props} />);
expect(havingWrapper.find('#select-op').prop('options')).to.have.lengthOf(9);
expect(havingWrapper.find('#select-op').prop('options')).to.have.lengthOf(6);
});
it('calls changeFilter when select is changed', () => {
@@ -75,7 +79,7 @@ describe('Filter', () => {
});
it('renders input for regex filters', () => {
const props = defaultProps;
const props = Object.assign({}, defaultProps);
props.filter = {
col: null,
op: 'regex',