QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-17 23:25:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(contextmenu): uncaught TypeError (#28203)

Browse Source
This commit is contained in:
sowo
2025-03-19 03:42:38 +01:00
committed by GitHub
parent 09ee3e2a1d
commit 29b62f7c0a
5 changed files with 64 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tests/unit_tests/common/test_query_object_factory.py
View File

@@ -40,7 +40,9 @@ def app_config() -> dict[str, Any]:
@fixture
def connector_registry() -> Mock:
return Mock(spec=["get_datasource"])
mock = Mock(spec=["get_datasource"])
mock.get_datasource().verbose_map = {"sum__num": "SUM", "unused": "UNUSED"}
return mock
def apply_max_row_limit(limit: int, max_limit: Optional[int] = None) -> int:
@@ -66,6 +68,11 @@ def raw_query_context() -> dict[str, Any]:
return QueryContextGenerator().generate("birth_names")
@fixture
def metric_label_raw_query_context() -> dict[str, Any]:
return QueryContextGenerator().generate("birth_names:metric_labels")
class TestQueryObjectFactory:
def test_query_context_limit_and_offset_defaults(
self,
@@ -107,3 +114,21 @@ class TestQueryObjectFactory:
raw_query_context["result_type"], **raw_query_object
)
assert query_object.post_processing == []
def test_query_context_metric_names(
self,
query_object_factory: QueryObjectFactory,
raw_query_context: dict[str, Any],
):
raw_query_context["queries"][0]["metrics"] = [
{"label": "sum__num"},
{"label": "num_girls"},
{"label": "num_boys"},
]
raw_query_object = raw_query_context["queries"][0]
query_object = query_object_factory.create(
raw_query_context["result_type"],
datasource=raw_query_context["datasource"],
**raw_query_object,
)
assert query_object.metric_names == ["SUM", "num_girls", "num_boys"]