QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-10 03:45:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

[sql-lab] make datasource name in visualize flow more descriptive (#2103)

Browse Source 
* make data source name more descriptive

* add user name to datasource name as well
This commit is contained in:
Alanna Scott
2017-02-09 12:11:25 -08:00
committed by GitHub
parent 80cfb08794
commit 2ace73e9a1
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
superset/assets/javascripts/SqlLab/components/VisualizeModal.jsx
View File

@@ -27,10 +27,9 @@ const defaultProps = {
class VisualizeModal extends React.PureComponent {
constructor(props) {
super(props);
const uniqueId = shortid.generate();
this.state = {
chartType: CHART_TYPES[0],
datasourceName: uniqueId,
datasourceName: this.datasourceName(),
columns: {},
hints: [],
};
@@ -54,6 +53,17 @@ class VisualizeModal extends React.PureComponent {
});
this.setState({ columns });
}
datasourceName() {
const { query } = this.props;
const uniqueId = shortid.generate();
let datasourceName = uniqueId;
if (query) {
datasourceName = query.user ? `${query.user}-` : '';
datasourceName += query.db ? `${query.db}-` : '';
datasourceName += `${query.tab}-${uniqueId}`;
}
return datasourceName;
}
validate() {
const hints = [];
const cols = this.mergedColumns();