QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 15:44:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): add login_as_admin in global conftest (#20703)

Browse Source
This commit is contained in:
Jesse Yang
2022-07-14 18:10:31 -07:00
committed by GitHub
parent 5beb1aa2f5
commit 2cb4fd31f1
27 changed files with 494 additions and 454 deletions
Download Patch File Download Diff File Expand all files Collapse all files

174
tests/integration_tests/explore/form_data/api_tests.py
View File

@@ -27,8 +27,6 @@ from superset.explore.form_data.commands.state import TemporaryExploreState
from superset.extensions import cache_manager
from superset.models.slice import Slice
from superset.utils.core import DatasourceType
from tests.integration_tests.base_tests import login
from tests.integration_tests.fixtures.client import client
from tests.integration_tests.fixtures.world_bank_dashboard import (
load_world_bank_dashboard_with_slices,
load_world_bank_data,
@@ -80,82 +78,85 @@ def cache(chart_id, admin_id, datasource):
cache_manager.explore_form_data_cache.set(KEY, entry)
def test_post(client, chart_id: int, datasource: SqlaTable):
login(client, "admin")
def test_post(test_client, login_as_admin, chart_id: int, datasource: SqlaTable):
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": INITIAL_FORM_DATA,
}
resp = client.post("api/v1/explore/form_data", json=payload)
resp = test_client.post("api/v1/explore/form_data", json=payload)
assert resp.status_code == 201
def test_post_bad_request_non_string(client, chart_id: int, datasource: SqlaTable):
login(client, "admin")
def test_post_bad_request_non_string(
test_client, login_as_admin, chart_id: int, datasource: SqlaTable
):
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": 1234,
}
resp = client.post("api/v1/explore/form_data", json=payload)
resp = test_client.post("api/v1/explore/form_data", json=payload)
assert resp.status_code == 400
def test_post_bad_request_non_json_string(client, chart_id: int, datasource: SqlaTable):
login(client, "admin")
def test_post_bad_request_non_json_string(
test_client, login_as_admin, chart_id: int, datasource: SqlaTable
):
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": "foo",
}
resp = client.post("api/v1/explore/form_data", json=payload)
resp = test_client.post("api/v1/explore/form_data", json=payload)
assert resp.status_code == 400
def test_post_access_denied(client, chart_id: int, datasource: SqlaTable):
login(client, "gamma")
def test_post_access_denied(
test_client, login_as, chart_id: int, datasource: SqlaTable
):
login_as("gamma")
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": INITIAL_FORM_DATA,
}
resp = client.post("api/v1/explore/form_data", json=payload)
resp = test_client.post("api/v1/explore/form_data", json=payload)
assert resp.status_code == 404
def test_post_same_key_for_same_context(client, chart_id: int, datasource: SqlaTable):
login(client, "admin")
def test_post_same_key_for_same_context(
test_client, login_as_admin, chart_id: int, datasource: SqlaTable
):
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": UPDATED_FORM_DATA,
}
resp = client.post("api/v1/explore/form_data?tab_id=1", json=payload)
resp = test_client.post("api/v1/explore/form_data?tab_id=1", json=payload)
data = json.loads(resp.data.decode("utf-8"))
first_key = data.get("key")
resp = client.post("api/v1/explore/form_data?tab_id=1", json=payload)
resp = test_client.post("api/v1/explore/form_data?tab_id=1", json=payload)
data = json.loads(resp.data.decode("utf-8"))
second_key = data.get("key")
assert first_key == second_key
def test_post_different_key_for_different_context(
client, chart_id: int, datasource: SqlaTable
test_client, login_as_admin, chart_id: int, datasource: SqlaTable
):
login(client, "admin")
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": UPDATED_FORM_DATA,
}
resp = client.post("api/v1/explore/form_data?tab_id=1", json=payload)
resp = test_client.post("api/v1/explore/form_data?tab_id=1", json=payload)
data = json.loads(resp.data.decode("utf-8"))
first_key = data.get("key")
payload = {
@@ -163,231 +164,235 @@ def test_post_different_key_for_different_context(
"datasource_type": datasource.type,
"form_data": json.dumps({"test": "initial value"}),
}
resp = client.post("api/v1/explore/form_data?tab_id=1", json=payload)
resp = test_client.post("api/v1/explore/form_data?tab_id=1", json=payload)
data = json.loads(resp.data.decode("utf-8"))
second_key = data.get("key")
assert first_key != second_key
def test_post_same_key_for_same_tab_id(client, chart_id: int, datasource: SqlaTable):
login(client, "admin")
def test_post_same_key_for_same_tab_id(
test_client, login_as_admin, chart_id: int, datasource: SqlaTable
):
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": json.dumps({"test": "initial value"}),
}
resp = client.post("api/v1/explore/form_data?tab_id=1", json=payload)
resp = test_client.post("api/v1/explore/form_data?tab_id=1", json=payload)
data = json.loads(resp.data.decode("utf-8"))
first_key = data.get("key")
resp = client.post("api/v1/explore/form_data?tab_id=1", json=payload)
resp = test_client.post("api/v1/explore/form_data?tab_id=1", json=payload)
data = json.loads(resp.data.decode("utf-8"))
second_key = data.get("key")
assert first_key == second_key
def test_post_different_key_for_different_tab_id(
client, chart_id: int, datasource: SqlaTable
test_client, login_as_admin, chart_id: int, datasource: SqlaTable
):
login(client, "admin")
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": json.dumps({"test": "initial value"}),
}
resp = client.post("api/v1/explore/form_data?tab_id=1", json=payload)
resp = test_client.post("api/v1/explore/form_data?tab_id=1", json=payload)
data = json.loads(resp.data.decode("utf-8"))
first_key = data.get("key")
resp = client.post("api/v1/explore/form_data?tab_id=2", json=payload)
resp = test_client.post("api/v1/explore/form_data?tab_id=2", json=payload)
data = json.loads(resp.data.decode("utf-8"))
second_key = data.get("key")
assert first_key != second_key
def test_post_different_key_for_no_tab_id(client, chart_id: int, datasource: SqlaTable):
login(client, "admin")
def test_post_different_key_for_no_tab_id(
test_client, login_as_admin, chart_id: int, datasource: SqlaTable
):
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": INITIAL_FORM_DATA,
}
resp = client.post("api/v1/explore/form_data", json=payload)
resp = test_client.post("api/v1/explore/form_data", json=payload)
data = json.loads(resp.data.decode("utf-8"))
first_key = data.get("key")
resp = client.post("api/v1/explore/form_data", json=payload)
resp = test_client.post("api/v1/explore/form_data", json=payload)
data = json.loads(resp.data.decode("utf-8"))
second_key = data.get("key")
assert first_key != second_key
def test_put(client, chart_id: int, datasource: SqlaTable):
login(client, "admin")
def test_put(test_client, login_as_admin, chart_id: int, datasource: SqlaTable):
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": UPDATED_FORM_DATA,
}
resp = client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
resp = test_client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
assert resp.status_code == 200
def test_put_same_key_for_same_tab_id(client, chart_id: int, datasource: SqlaTable):
login(client, "admin")
def test_put_same_key_for_same_tab_id(
test_client, login_as_admin, chart_id: int, datasource: SqlaTable
):
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": UPDATED_FORM_DATA,
}
resp = client.put(f"api/v1/explore/form_data/{KEY}?tab_id=1", json=payload)
resp = test_client.put(f"api/v1/explore/form_data/{KEY}?tab_id=1", json=payload)
data = json.loads(resp.data.decode("utf-8"))
first_key = data.get("key")
resp = client.put(f"api/v1/explore/form_data/{KEY}?tab_id=1", json=payload)
resp = test_client.put(f"api/v1/explore/form_data/{KEY}?tab_id=1", json=payload)
data = json.loads(resp.data.decode("utf-8"))
second_key = data.get("key")
assert first_key == second_key
def test_put_different_key_for_different_tab_id(
client, chart_id: int, datasource: SqlaTable
test_client, login_as_admin, chart_id: int, datasource: SqlaTable
):
login(client, "admin")
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": UPDATED_FORM_DATA,
}
resp = client.put(f"api/v1/explore/form_data/{KEY}?tab_id=1", json=payload)
resp = test_client.put(f"api/v1/explore/form_data/{KEY}?tab_id=1", json=payload)
data = json.loads(resp.data.decode("utf-8"))
first_key = data.get("key")
resp = client.put(f"api/v1/explore/form_data/{KEY}?tab_id=2", json=payload)
resp = test_client.put(f"api/v1/explore/form_data/{KEY}?tab_id=2", json=payload)
data = json.loads(resp.data.decode("utf-8"))
second_key = data.get("key")
assert first_key != second_key
def test_put_different_key_for_no_tab_id(client, chart_id: int, datasource: SqlaTable):
login(client, "admin")
def test_put_different_key_for_no_tab_id(
test_client, login_as_admin, chart_id: int, datasource: SqlaTable
):
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": UPDATED_FORM_DATA,
}
resp = client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
resp = test_client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
data = json.loads(resp.data.decode("utf-8"))
first_key = data.get("key")
resp = client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
resp = test_client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
data = json.loads(resp.data.decode("utf-8"))
second_key = data.get("key")
assert first_key != second_key
def test_put_bad_request(client, chart_id: int, datasource: SqlaTable):
login(client, "admin")
def test_put_bad_request(
test_client, login_as_admin, chart_id: int, datasource: SqlaTable
):
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": 1234,
}
resp = client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
resp = test_client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
assert resp.status_code == 400
def test_put_bad_request_non_string(client, chart_id: int, datasource: SqlaTable):
login(client, "admin")
def test_put_bad_request_non_string(
test_client, login_as_admin, chart_id: int, datasource: SqlaTable
):
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": 1234,
}
resp = client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
resp = test_client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
assert resp.status_code == 400
def test_put_bad_request_non_json_string(client, chart_id: int, datasource: SqlaTable):
login(client, "admin")
def test_put_bad_request_non_json_string(
test_client, login_as_admin, chart_id: int, datasource: SqlaTable
):
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": "foo",
}
resp = client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
resp = test_client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
assert resp.status_code == 400
def test_put_access_denied(client, chart_id: int, datasource: SqlaTable):
login(client, "gamma")
def test_put_access_denied(test_client, login_as, chart_id: int, datasource: SqlaTable):
login_as("gamma")
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": UPDATED_FORM_DATA,
}
resp = client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
resp = test_client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
assert resp.status_code == 404
def test_put_not_owner(client, chart_id: int, datasource: SqlaTable):
login(client, "gamma")
def test_put_not_owner(test_client, login_as, chart_id: int, datasource: SqlaTable):
login_as("gamma")
payload = {
"datasource_id": datasource.id,
"datasource_type": datasource.type,
"chart_id": chart_id,
"form_data": UPDATED_FORM_DATA,
}
resp = client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
resp = test_client.put(f"api/v1/explore/form_data/{KEY}", json=payload)
assert resp.status_code == 404
def test_get_key_not_found(client):
login(client, "admin")
resp = client.get(f"api/v1/explore/form_data/unknown-key")
def test_get_key_not_found(test_client, login_as_admin):
resp = test_client.get(f"api/v1/explore/form_data/unknown-key")
assert resp.status_code == 404
def test_get(client):
login(client, "admin")
resp = client.get(f"api/v1/explore/form_data/{KEY}")
def test_get(test_client, login_as_admin):
resp = test_client.get(f"api/v1/explore/form_data/{KEY}")
assert resp.status_code == 200
data = json.loads(resp.data.decode("utf-8"))
assert INITIAL_FORM_DATA == data.get("form_data")
def test_get_access_denied(client):
login(client, "gamma")
resp = client.get(f"api/v1/explore/form_data/{KEY}")
def test_get_access_denied(test_client, login_as):
login_as("gamma")
resp = test_client.get(f"api/v1/explore/form_data/{KEY}")
assert resp.status_code == 404
@patch("superset.security.SupersetSecurityManager.can_access_datasource")
def test_get_dataset_access_denied(mock_can_access_datasource, client):
def test_get_dataset_access_denied(
mock_can_access_datasource, test_client, login_as_admin
):
mock_can_access_datasource.side_effect = DatasetAccessDeniedError()
login(client, "admin")
resp = client.get(f"api/v1/explore/form_data/{KEY}")
resp = test_client.get(f"api/v1/explore/form_data/{KEY}")
assert resp.status_code == 403
def test_delete(client):
login(client, "admin")
resp = client.delete(f"api/v1/explore/form_data/{KEY}")
def test_delete(test_client, login_as_admin):
resp = test_client.delete(f"api/v1/explore/form_data/{KEY}")
assert resp.status_code == 200
def test_delete_access_denied(client):
login(client, "gamma")
resp = client.delete(f"api/v1/explore/form_data/{KEY}")
def test_delete_access_denied(test_client, login_as):
login_as("gamma")
resp = test_client.delete(f"api/v1/explore/form_data/{KEY}")
assert resp.status_code == 404
def test_delete_not_owner(client, chart_id: int, datasource: SqlaTable, admin_id: int):
def test_delete_not_owner(
test_client, login_as_admin, chart_id: int, datasource: SqlaTable, admin_id: int
):
another_key = "another_key"
another_owner = admin_id + 1
entry: TemporaryExploreState = {
@@ -398,6 +403,5 @@ def test_delete_not_owner(client, chart_id: int, datasource: SqlaTable, admin_id
"form_data": INITIAL_FORM_DATA,
}
cache_manager.explore_form_data_cache.set(another_key, entry)
login(client, "admin")
resp = client.delete(f"api/v1/explore/form_data/{another_key}")
resp = test_client.delete(f"api/v1/explore/form_data/{another_key}")
assert resp.status_code == 403