chore: set up ruff as a new linter/formatter (#28158)

This commit is contained in:
Maxime Beauchemin
2024-04-24 17:19:53 -07:00
committed by GitHub
parent e8a678b75a
commit 2d63722150
579 changed files with 2508 additions and 2542 deletions

View File

@@ -16,6 +16,7 @@
# under the License.
# isort:skip_file
"""Unit tests for Superset"""
from datetime import datetime
import json
@@ -44,8 +45,8 @@ from tests.integration_tests.base_tests import SupersetTestCase
from tests.integration_tests.conftest import with_feature_flags
from tests.integration_tests.constants import ADMIN_USERNAME, GAMMA_USERNAME
from tests.integration_tests.fixtures.birth_names_dashboard import (
load_birth_names_dashboard_with_slices,
load_birth_names_data,
load_birth_names_dashboard_with_slices, # noqa: F401
load_birth_names_data, # noqa: F401
)
from tests.integration_tests.reports.utils import insert_report_schedule
@@ -311,7 +312,7 @@ class TestReportSchedulesApi(SupersetTestCase):
ReportSchedule API: Test info
"""
self.login(ADMIN_USERNAME)
uri = f"api/v1/report/_info"
uri = "api/v1/report/_info" # noqa: F541
rv = self.get_assert_metric(uri, "info")
assert rv.status_code == 200
@@ -346,7 +347,7 @@ class TestReportSchedulesApi(SupersetTestCase):
ReportSchedule Api: Test get list report schedules
"""
self.login(ADMIN_USERNAME)
uri = f"api/v1/report/"
uri = "api/v1/report/" # noqa: F541
rv = self.get_assert_metric(uri, "get_list")
expected_fields = [
@@ -425,7 +426,7 @@ class TestReportSchedulesApi(SupersetTestCase):
ReportSchedule Api: Test get list report schedules for different roles
"""
self.login(username)
uri = f"api/v1/report/"
uri = "api/v1/report/" # noqa: F541
rv = self.get_assert_metric(uri, "get_list")
assert rv.status_code == 200
@@ -437,7 +438,7 @@ class TestReportSchedulesApi(SupersetTestCase):
ReportSchedule Api: Test get list report schedules for regular gamma user
"""
self.login(GAMMA_USERNAME)
uri = f"api/v1/report/"
uri = "api/v1/report/" # noqa: F541
rv = self.client.get(uri)
assert rv.status_code == 403
@@ -915,9 +916,9 @@ class TestReportSchedulesApi(SupersetTestCase):
ReportSchedule Api: Test create report schedule with unsaved chart
"""
self.login(ADMIN_USERNAME)
chart = db.session.query(Slice).first()
dashboard = db.session.query(Dashboard).first()
example_db = get_example_database()
db.session.query(Slice).first() # noqa: F841
db.session.query(Dashboard).first() # noqa: F841
get_example_database() # noqa: F841
report_schedule_data = {
"type": ReportScheduleType.REPORT,
@@ -944,9 +945,9 @@ class TestReportSchedulesApi(SupersetTestCase):
ReportSchedule Api: Test create report schedule with no dashboard id
"""
self.login(ADMIN_USERNAME)
chart = db.session.query(Slice).first()
dashboard = db.session.query(Dashboard).first()
example_db = get_example_database()
db.session.query(Slice).first() # noqa: F841
db.session.query(Dashboard).first() # noqa: F841
get_example_database() # noqa: F841
report_schedule_data = {
"type": ReportScheduleType.REPORT,
"name": "name3",
@@ -972,8 +973,8 @@ class TestReportSchedulesApi(SupersetTestCase):
"""
self.login(ADMIN_USERNAME)
chart = db.session.query(Slice).first()
dashboard = db.session.query(Dashboard).first()
example_db = get_example_database()
db.session.query(Dashboard).first() # noqa: F841
get_example_database() # noqa: F841
report_schedule_data = {
"type": ReportScheduleType.REPORT,
"name": "name4",
@@ -1029,9 +1030,9 @@ class TestReportSchedulesApi(SupersetTestCase):
ReportSchedule Api: Test create multiple reports with the same creation method
"""
self.login(ADMIN_USERNAME)
chart = db.session.query(Slice).first()
db.session.query(Slice).first() # noqa: F841
dashboard = db.session.query(Dashboard).first()
example_db = get_example_database()
get_example_database() # noqa: F841
report_schedule_data = {
"type": ReportScheduleType.REPORT,
"name": "name4",
@@ -1475,7 +1476,7 @@ class TestReportSchedulesApi(SupersetTestCase):
"description": "Updated description",
}
uri = f"api/v1/report/{existing_report.id}"
rv = self.put_assert_metric(uri, report_schedule_data, "put")
self.put_assert_metric(uri, report_schedule_data, "put") # noqa: F841
updated_report = (
db.session.query(ReportSchedule)
.filter(ReportSchedule.name == "name1")
@@ -1498,7 +1499,7 @@ class TestReportSchedulesApi(SupersetTestCase):
"owners": [],
}
uri = f"api/v1/report/{existing_report.id}"
rv = self.put_assert_metric(uri, report_schedule_data, "put")
self.put_assert_metric(uri, report_schedule_data, "put") # noqa: F841
updated_report = (
db.session.query(ReportSchedule)
.filter(ReportSchedule.name == "name1")
@@ -1525,7 +1526,7 @@ class TestReportSchedulesApi(SupersetTestCase):
"owners": [],
}
uri = f"api/v1/report/{existing_report.id}"
rv = self.put_assert_metric(uri, report_update_data, "put")
self.put_assert_metric(uri, report_update_data, "put")
updated_report = (
db.session.query(ReportSchedule)
.filter(ReportSchedule.name == "name1")
@@ -1538,7 +1539,7 @@ class TestReportSchedulesApi(SupersetTestCase):
"owners": [gamma.id],
}
uri = f"api/v1/report/{updated_report.id}"
rv = self.put_assert_metric(uri, report_update_data, "put")
self.put_assert_metric(uri, report_update_data, "put") # noqa: F841
updated_report = (
db.session.query(ReportSchedule)
.filter(ReportSchedule.name == "name1")