QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-23 01:55:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Re-enable rule no-else-return (#10861)

Browse Source
This commit is contained in:
Kamil Gabryjelski
2020-09-14 22:00:07 +02:00
committed by GitHub
parent 76275ec410
commit 2d8f4e3aaf
31 changed files with 135 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
superset-frontend/src/SqlLab/components/EstimateQueryCostButton.jsx
View File

@@ -61,7 +61,8 @@ class EstimateQueryCostButton extends React.PureComponent {
{this.props.queryCostEstimate.error}
</Alert>
);
} else if (this.props.queryCostEstimate.completed) {
}
if (this.props.queryCostEstimate.completed) {
return (
<Table
className="table cost-estimate"

15
superset-frontend/src/SqlLab/components/ResultSet.tsx
View File

@@ -216,7 +216,8 @@ export default class ResultSet extends React.PureComponent<
if (query.state === 'stopped') {
return <Alert bsStyle="warning">Query was stopped</Alert>;
} else if (query.state === 'failed') {
}
if (query.state === 'failed') {
return (
<div className="result-set-error-message">
<ErrorMessageWithStackTrace
@@ -227,7 +228,8 @@ export default class ResultSet extends React.PureComponent<
/>
</div>
);
} else if (query.state === 'success' && query.ctas) {
}
if (query.state === 'success' && query.ctas) {
const { tempSchema, tempTable } = query;
let object = 'Table';
if (query.ctas_method === CtasEnum.VIEW) {
@@ -262,7 +264,8 @@ export default class ResultSet extends React.PureComponent<
</Alert>
</div>
);
} else if (query.state === 'success' && query.results) {
}
if (query.state === 'success' && query.results) {
const { results } = query;
let data;
if (this.props.cache && query.cached) {
@@ -287,7 +290,8 @@ export default class ResultSet extends React.PureComponent<
/>
</>
);
} else if (data && data.length === 0) {
}
if (data && data.length === 0) {
return (
<Alert bsStyle="warning">{t('The query returned no data')}</Alert>
);
@@ -310,7 +314,8 @@ export default class ResultSet extends React.PureComponent<
{t('Fetch data preview')}
</Button>
);
} else if (query.resultsKey) {
}
if (query.resultsKey) {
return (
<Button
buttonSize="sm"

3
superset-frontend/src/SqlLab/components/RunQueryActionButton.tsx
View File

@@ -59,7 +59,8 @@ const RunQueryActionButton = ({
<i className="fa fa-stop" /> {t('Stop')}
</Button>
);
} else if (allowAsync) {
}
if (allowAsync) {
return (
<Button
{...commonBtnProps}

3
superset-frontend/src/SqlLab/components/TableElement.jsx
View File

@@ -238,7 +238,8 @@ class TableElement extends React.PureComponent {
const colB = b.name.toUpperCase();
if (colA < colB) {
return -1;
} else if (colA > colB) {
}
if (colA > colB) {
return 1;
}
return 0;