perf(export): export generates unnecessary files content (#26765)

2026-05-06 16:34:32 +00:00 · 2024-02-22 02:28:38 +03:00
parent 744f68d637
commit 2e4f6d3f38
23 changed files with 279 additions and 176 deletions
--- a/superset/commands/export/assets.py
+++ b/superset/commands/export/assets.py
@@ -1,63 +1,64 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-from collections.abc import Iterator
-from datetime import datetime, timezone
-
-import yaml
-
-from superset.commands.base import BaseCommand
-from superset.commands.chart.export import ExportChartsCommand
-from superset.commands.dashboard.export import ExportDashboardsCommand
-from superset.commands.database.export import ExportDatabasesCommand
-from superset.commands.dataset.export import ExportDatasetsCommand
-from superset.commands.query.export import ExportSavedQueriesCommand
-from superset.utils.dict_import_export import EXPORT_VERSION
-
-METADATA_FILE_NAME = "metadata.yaml"
-
-
-class ExportAssetsCommand(BaseCommand):
-    """
-    Command that exports all databases, datasets, charts, dashboards and saved queries.
-    """
-
-    def run(self) -> Iterator[tuple[str, str]]:
-        metadata = {
-            "version": EXPORT_VERSION,
-            "type": "assets",
-            "timestamp": datetime.now(tz=timezone.utc).isoformat(),
-        }
-        yield METADATA_FILE_NAME, yaml.safe_dump(metadata, sort_keys=False)
-        seen = {METADATA_FILE_NAME}
-
-        commands = [
-            ExportDatabasesCommand,
-            ExportDatasetsCommand,
-            ExportChartsCommand,
-            ExportDashboardsCommand,
-            ExportSavedQueriesCommand,
-        ]
-        for command in commands:
-            ids = [model.id for model in command.dao.find_all()]
-            for file_name, file_content in command(ids, export_related=False).run():
-                if file_name not in seen:
-                    yield file_name, file_content
-                    seen.add(file_name)
-
-    def validate(self) -> None:
-        pass
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from collections.abc import Iterator
+from datetime import datetime, timezone
+from typing import Callable
+
+import yaml
+
+from superset.commands.base import BaseCommand
+from superset.commands.chart.export import ExportChartsCommand
+from superset.commands.dashboard.export import ExportDashboardsCommand
+from superset.commands.database.export import ExportDatabasesCommand
+from superset.commands.dataset.export import ExportDatasetsCommand
+from superset.commands.query.export import ExportSavedQueriesCommand
+from superset.utils.dict_import_export import EXPORT_VERSION
+
+METADATA_FILE_NAME = "metadata.yaml"
+
+
+class ExportAssetsCommand(BaseCommand):
+    """
+    Command that exports all databases, datasets, charts, dashboards and saved queries.
+    """
+
+    def run(self) -> Iterator[tuple[str, Callable[[], str]]]:
+        metadata = {
+            "version": EXPORT_VERSION,
+            "type": "assets",
+            "timestamp": datetime.now(tz=timezone.utc).isoformat(),
+        }
+        yield METADATA_FILE_NAME, lambda: yaml.safe_dump(metadata, sort_keys=False)
+        seen = {METADATA_FILE_NAME}
+
+        commands = [
+            ExportDatabasesCommand,
+            ExportDatasetsCommand,
+            ExportChartsCommand,
+            ExportDashboardsCommand,
+            ExportSavedQueriesCommand,
+        ]
+        for command in commands:
+            ids = [model.id for model in command.dao.find_all()]
+            for file_name, file_content in command(ids, export_related=False).run():
+                if file_name not in seen:
+                    yield file_name, file_content
+                    seen.add(file_name)
+
+    def validate(self) -> None:
+        pass