QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(export): export generates unnecessary files content (#26765)

Browse Source
This commit is contained in:
Stepan
2024-02-22 02:28:38 +03:00
committed by GitHub
parent 744f68d637
commit 2e4f6d3f38
23 changed files with 279 additions and 176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/integration_tests/charts/commands_tests.py
View File

@@ -75,7 +75,7 @@ class TestExportChartsCommand(SupersetTestCase):
assert expected == list(contents.keys())
metadata = yaml.safe_load(
contents[f"charts/Energy_Sankey_{example_chart.id}.yaml"]
contents[f"charts/Energy_Sankey_{example_chart.id}.yaml"]()
)
assert metadata == {
@@ -133,7 +133,7 @@ class TestExportChartsCommand(SupersetTestCase):
contents = dict(command.run())
metadata = yaml.safe_load(
contents[f"charts/Energy_Sankey_{example_chart.id}.yaml"]
contents[f"charts/Energy_Sankey_{example_chart.id}.yaml"]()
)
assert list(metadata.keys()) == [
"slice_name",

4
tests/integration_tests/dashboards/commands_tests.py
View File

@@ -78,7 +78,7 @@ class TestExportDashboardsCommand(SupersetTestCase):
assert expected_paths == set(contents.keys())
metadata = yaml.safe_load(
contents[f"dashboards/World_Banks_Data_{example_dashboard.id}.yaml"]
contents[f"dashboards/World_Banks_Data_{example_dashboard.id}.yaml"]()
)
# remove chart UUIDs from metadata so we can compare
@@ -269,7 +269,7 @@ class TestExportDashboardsCommand(SupersetTestCase):
contents = dict(command.run())
metadata = yaml.safe_load(
contents[f"dashboards/World_Banks_Data_{example_dashboard.id}.yaml"]
contents[f"dashboards/World_Banks_Data_{example_dashboard.id}.yaml"]()
)
assert list(metadata.keys()) == [
"dashboard_title",

6
tests/integration_tests/databases/commands_tests.py
View File

@@ -158,7 +158,7 @@ class TestExportDatabasesCommand(SupersetTestCase):
big_int_type = "BIGINT(20)"
else:
big_int_type = "BIGINT"
metadata = yaml.safe_load(contents["databases/examples.yaml"])
metadata = yaml.safe_load(contents["databases/examples.yaml"]())
assert metadata == (
{
"allow_csv_upload": True,
@@ -176,7 +176,7 @@ class TestExportDatabasesCommand(SupersetTestCase):
}
)
metadata = yaml.safe_load(contents["datasets/examples/birth_names.yaml"])
metadata = yaml.safe_load(contents["datasets/examples/birth_names.yaml"]())
metadata.pop("uuid")
metadata["columns"].sort(key=lambda x: x["column_name"])
@@ -359,7 +359,7 @@ class TestExportDatabasesCommand(SupersetTestCase):
command = ExportDatabasesCommand([example_db.id])
contents = dict(command.run())
metadata = yaml.safe_load(contents["databases/examples.yaml"])
metadata = yaml.safe_load(contents["databases/examples.yaml"]())
assert list(metadata.keys()) == [
"database_name",
"sqlalchemy_uri",

4
tests/integration_tests/datasets/commands_tests.py
View File

@@ -82,7 +82,7 @@ class TestExportDatasetsCommand(SupersetTestCase):
"databases/examples.yaml",
]
metadata = yaml.safe_load(contents["datasets/examples/energy_usage.yaml"])
metadata = yaml.safe_load(contents["datasets/examples/energy_usage.yaml"]())
# sort columns for deterministic comparison
metadata["columns"] = sorted(metadata["columns"], key=itemgetter("column_name"))
@@ -216,7 +216,7 @@ class TestExportDatasetsCommand(SupersetTestCase):
command = ExportDatasetsCommand([example_dataset.id])
contents = dict(command.run())
metadata = yaml.safe_load(contents["datasets/examples/energy_usage.yaml"])
metadata = yaml.safe_load(contents["datasets/examples/energy_usage.yaml"]())
assert list(metadata.keys()) == [
"table_name",
"main_dttm_col",

2
tests/integration_tests/importexport/commands_tests.py
View File

@@ -38,7 +38,7 @@ class TestExportModelsCommand(SupersetTestCase):
command = ExportDatabasesCommand([example_db.id])
contents = dict(command.run())
metadata = yaml.safe_load(contents["metadata.yaml"])
metadata = yaml.safe_load(contents["metadata.yaml"]())
assert metadata == (
{
"version": "1.0.0",

8
tests/integration_tests/queries/saved_queries/commands_tests.py
View File

@@ -70,7 +70,9 @@ class TestExportSavedQueriesCommand(SupersetTestCase):
]
assert expected == list(contents.keys())
metadata = yaml.safe_load(contents["queries/examples/schema1/The_answer.yaml"])
metadata = yaml.safe_load(
contents["queries/examples/schema1/The_answer.yaml"]()
)
assert metadata == {
"schema": "schema1",
"label": "The answer",
@@ -127,7 +129,9 @@ class TestExportSavedQueriesCommand(SupersetTestCase):
command = ExportSavedQueriesCommand([self.example_query.id])
contents = dict(command.run())
metadata = yaml.safe_load(contents["queries/examples/schema1/The_answer.yaml"])
metadata = yaml.safe_load(
contents["queries/examples/schema1/The_answer.yaml"]()
)
assert list(metadata.keys()) == [
"schema",
"label",