QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: V1 charts load cypress tests (#11685)

Browse Source 
* Enabled assertion on v1 chart request

* added missing code after rebase

* extracted alias logic to function

* modified v1 requests to contain form data, added assertion on ui elements using slice id from request
This commit is contained in:
adam-stasiak-polidea
2020-11-16 08:08:35 +01:00
committed by GitHub
parent 700c7c524e
commit 2f036e9359
5 changed files with 57 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
superset-frontend/src/chart/chartAction.js
View File

@@ -152,9 +152,12 @@ const v1ChartDataRequest = async (
});
// The dashboard id is added to query params for tracking purposes
const qs = requestParams.dashboard_id
? { dashboard_id: requestParams.dashboard_id }
: {};
const { slice_id: sliceId } = formData;
const { dashboard_id: dashboardId } = requestParams;
const qs = {};
if (sliceId !== undefined) qs.form_data = `{"slice_id":${sliceId}}`;
if (dashboardId !== undefined) qs.dashboard_id = dashboardId;
const allowDomainSharding =
// eslint-disable-next-line camelcase
domainShardingEnabled && requestParams?.dashboard_id;