QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: keep placeholder in multivalue select when a value exists (#11181)

Browse Source
This commit is contained in:
Elizabeth Thompson
2020-10-13 13:45:31 -07:00
committed by GitHub
parent d7eb1d476f
commit 31cc4155b7
4 changed files with 94 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx
View File

@@ -267,7 +267,7 @@ export default class AdhocFilterControl extends React.Component {
<OnPasteSelect
isMulti
name={`select-${this.props.name}`}
placeholder={t('choose a column or metric')}
placeholder={t('choose one or more column or metric')}
options={this.state.options}
value={this.state.values}
labelKey="label"

6
superset-frontend/src/explore/components/controls/MetricsControl.jsx
View File

@@ -337,7 +337,11 @@ export default class MetricsControl extends React.PureComponent {
<OnPasteSelect
isMulti={this.props.multi}
name={`select-${this.props.name}`}
placeholder={t('choose a column or aggregate function')}
placeholder={
this.props.multi
? t('choose one or more column or aggregate function')
: t('choose a column or aggregate function')
}
options={this.state.options}
value={this.state.value}
labelKey="label"