From 3276a653e3d92f2ed3ac7ce8cef210b68bc39c2a Mon Sep 17 00:00:00 2001 From: Erik Ritter Date: Fri, 20 Aug 2021 14:39:29 -0700 Subject: [PATCH] fix: Improve big number time format UX (#1320) * fix: Improve big number time format UX * Update controlPanel.tsx --- .../src/BigNumber/controlPanel.tsx | 29 ++++++++----------- 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/controlPanel.tsx b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/controlPanel.tsx index 62ee65ab622..f3e4ee98d5b 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/controlPanel.tsx +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/controlPanel.tsx @@ -62,18 +62,6 @@ const config: ControlPanelConfig = { }, ], ['y_axis_format'], - [ - { - name: 'show_timestamp', - config: { - type: 'CheckboxControl', - label: t('Show Timestamp'), - renderTrigger: true, - default: false, - description: t('Whether to display the timestamp'), - }, - }, - ], [ { name: 'time_format', @@ -83,12 +71,19 @@ const config: ControlPanelConfig = { label: t('Timestamp format'), renderTrigger: true, choices: D3_TIME_FORMAT_OPTIONS, - default: '%d-%m-%Y %H:%M:%S', description: D3_FORMAT_DOCS, - visibility(props) { - const { show_timestamp } = props.form_data; - return !!show_timestamp; - }, + }, + }, + ], + [ + { + name: 'show_timestamp', + config: { + type: 'CheckboxControl', + label: t('Show Timestamp'), + renderTrigger: true, + default: false, + description: t('Whether to display the timestamp'), }, }, ],