QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 00:54:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(sqllab): log error_detail on fetch failed (#23377)

Browse Source
This commit is contained in:
JUST.in DO IT
2023-03-20 10:08:27 -07:00
committed by GitHub
parent b0d83e8c50
commit 3277ea83ea
3 changed files with 48 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
superset-frontend/src/SqlLab/actions/sqlLab.test.js
View File

@@ -24,6 +24,7 @@ import thunk from 'redux-thunk';
import shortid from 'shortid';
import * as featureFlags from 'src/featureFlags';
import * as actions from 'src/SqlLab/actions/sqlLab';
import { LOG_EVENT } from 'src/logger/actions';
import {
defaultQueryEditor,
query,
@@ -240,22 +241,38 @@ describe('async actions', () => {
});
});
it('calls queryFailed on fetch error', () => {
expect.assertions(1);
it('calls queryFailed on fetch error and logs the error details', () => {
expect.assertions(3);
fetchMock.post(
runQueryEndpoint,
{ throws: { message: 'error text' } },
{
throws: {
message: 'error text',
timeout: true,
statusText: 'timeout',
},
},
{ overwriteRoutes: true },
);
const store = mockStore({});
const expectedActionTypes = [actions.START_QUERY, actions.QUERY_FAILED];
const expectedActionTypes = [
actions.START_QUERY,
LOG_EVENT,
LOG_EVENT,
actions.QUERY_FAILED,
];
const { dispatch } = store;
const request = actions.runQuery(query);
return request(dispatch, () => initialState).then(() => {
expect(store.getActions().map(a => a.type)).toEqual(
expectedActionTypes,
const actions = store.getActions();
expect(actions.map(a => a.type)).toEqual(expectedActionTypes);
expect(actions[1].payload.eventData.error_details).toContain(
'Issue 1000',
);
expect(actions[2].payload.eventData.error_details).toContain(
'Issue 1001',
);
});
});