QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 17:14:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixing explore actions & slice controller interactions (#1292)

Browse Source 
* Fixing explore actions & slice controller interactions

* Addressing a comment
This commit is contained in:
Maxime Beauchemin
2016-10-07 14:06:26 -07:00
committed by GitHub
parent 382b8e85da
commit 3384e7598e
9 changed files with 150 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
caravel/assets/javascripts/explore/components/URLShortLinkButton.jsx
View File

@@ -13,8 +13,6 @@ export default class URLShortLinkButton extends React.Component {
this.state = {
shortUrl: '',
};
this.getShortUrl();
}
getShortUrl() {
@@ -22,7 +20,7 @@ export default class URLShortLinkButton extends React.Component {
type: 'POST',
url: '/r/shortner/',
data: {
data: '/' + window.location.pathname + this.props.slice.querystring(),
data: '/' + window.location.pathname + window.location.search,
},
success: (data) => {
this.setState({
@@ -51,16 +49,15 @@ export default class URLShortLinkButton extends React.Component {
}
render() {
const shortUrl = this.state.shortUrl;
const isDisabled = shortUrl === '';
return (
<OverlayTrigger
trigger="click"
rootClose
placement="left"
onEnter={this.getShortUrl.bind(this)}
overlay={this.renderPopover()}
>
<span className="btn btn-default btn-sm" disabled={isDisabled}>
<span className="btn btn-default btn-sm">
<i className="fa fa-link"></i>&nbsp;
</span>
</OverlayTrigger>