QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-17 07:05:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve function detection (#33306)

Browse Source
This commit is contained in:
Beto Dealmeida
2025-05-01 13:45:03 -04:00
committed by GitHub
parent 3c6091144b
commit 339ba96600
4 changed files with 71 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
tests/unit_tests/sql_parse_tests.py
View File

@@ -1237,6 +1237,35 @@ def test_check_sql_functions_exist() -> None:
)
def test_check_sql_functions_exist_with_comments() -> None:
"""
Test sql functions are detected correctly with comments
"""
assert not (
check_sql_functions_exist(
"select a, b from version/**/", {"version"}, "postgresql"
)
)
assert check_sql_functions_exist("select version/**/()", {"version"}, "postgresql")
assert check_sql_functions_exist(
"select version from version/**/()", {"version"}, "postgresql"
)
assert check_sql_functions_exist(
"select 1, a.version from (select version from version/**/()) as a",
{"version"},
"postgresql",
)
assert check_sql_functions_exist(
"select 1, a.version from (select version/**/()) as a",
{"version"},
"postgresql",
)
def test_sanitize_clause_valid():
# regular clauses
assert sanitize_clause("col = 1") == "col = 1"