QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove unnecessary exception when exploring non-legacy viz plugins (#10538)

Browse Source 
* fix: remove unnecessary exception when exploring non-legacy viz plugins

* lint
This commit is contained in:
Ville Brofeldt
2020-08-07 08:41:39 +03:00
committed by GitHub
parent 0bad77f0fe
commit 363abfa1a5
4 changed files with 26 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
superset/models/slice.py
View File

@@ -155,10 +155,12 @@ class Slice(
@property # type: ignore
@utils.memoized
def viz(self) -> BaseViz:
def viz(self) -> Optional[BaseViz]:
form_data = json.loads(self.params)
viz_class = viz_types[self.viz_type]
return viz_class(datasource=self.datasource, form_data=form_data)
viz_class = viz_types.get(self.viz_type)
if viz_class:
return viz_class(datasource=self.datasource, form_data=form_data)
return None
@property
def description_markeddown(self) -> str:
@@ -170,8 +172,9 @@ class Slice(
data: Dict[str, Any] = {}
self.token = ""
try:
data = self.viz.data
self.token = data.get("token") # type: ignore
viz = self.viz
data = viz.data if viz else self.form_data
self.token = utils.get_form_data_token(data)
except Exception as ex: # pylint: disable=broad-except
logger.exception(ex)
data["error"] = str(ex)