QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-11 19:05:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Loading overlay bugfix and cleanup (#10105)

Browse Source 
* fix: reordering DOM output, simplifying styles, Emotionalizing

* simplification

* converting RefreshChartOverlay to TS

* Loading -> TS, stripping unused size prop

* simplification...

* just letting "position" prop act as a class name. Simpler!

* consolidating styles, changing a className prop to a position prop.

* nixing (unused) classname prop

* replacing inline loading img with the proper Loading component

* BY THERE.

* position prop is optional!
This commit is contained in:
Evan Rusackas
2020-06-24 14:21:45 -07:00
committed by GitHub
parent c544ebd876
commit 36ea42f092
10 changed files with 70 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
superset-frontend/src/explore/components/DisplayQueryButton.jsx
View File

@@ -208,13 +208,7 @@ export class DisplayQueryButton extends React.PureComponent {
}
renderSamplesModalBody() {
if (this.state.isLoading) {
return (
<img
className="loading"
alt="Loading..."
src="/static/assets/images/loading.gif"
/>
);
return <Loading />;
} else if (this.state.error) {
return <pre>{this.state.error}</pre>;
} else if (this.state.data) {