QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 17:14:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

[explore v2] add scrollbar to control panel container (#1284)

Browse Source 
* add scroll bars to control panel container

* make query and save-btns block elements

* don't use react component, use custom styles

* move style to stylesheet
This commit is contained in:
Alanna Scott
2016-10-07 11:57:05 -07:00
committed by GitHub
parent 0a3121c243
commit 382b8e85da
5 changed files with 31 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
caravel/assets/javascripts/explorev2/components/ControlPanelsContainer.jsx
View File

@@ -14,8 +14,12 @@ const defaultProps = {
function ControlPanelsContainer(props) {
return (
<Panel>
{DefaultControls}
{VIZ_CONTROL_MAPPING[props.vizType]}
<div className="scrollbar-container">
<div className="scrollbar-content">
{DefaultControls}
{VIZ_CONTROL_MAPPING[props.vizType]}
</div>
</div>
</Panel>
);
}

8
caravel/assets/javascripts/explorev2/components/ExploreViewContainer.jsx
View File

@@ -31,16 +31,16 @@ export default class ExploreViewContainer extends React.Component {
overflow: 'hidden',
}}
>
<div className="row table-body">
<div className="table-cell col-sm-4">
<div className="row">
<div className="col-sm-4">
<QueryAndSaveButtons
canAdd="True"
onQuery={() => {}}
/>
<br /><br />
<br />
<ControlPanelsContainer />
</div>
<div className="table-cell col-sm-8">
<div className="col-sm-8">
<ChartContainer
viz={this.props.data.viz}
height={this.state.height}

13
caravel/assets/javascripts/explorev2/components/QueryAndSaveButtons.jsx
View File

@@ -7,23 +7,22 @@ const propTypes = {
};
export default function QueryAndSaveBtns({ canAdd, onQuery }) {
const saveClasses = classnames('btn btn-default btn-sm', {
const saveClasses = classnames('btn btn-default btn-block btn-sm', {
'disabled disabledButton': canAdd !== 'True',
});
return (
<div className="btn-group query-and-save">
<button type="button" className="btn btn-primary btn-sm" onClick={onQuery}>
<div className="btn-group btn-group-justified query-and-save">
<a className="btn btn-primary btn-block btn-sm" onClick={onQuery}>
<i className="fa fa-bolt"></i> Query
</button>
<button
type="button"
</a>
<a
className={saveClasses}
data-target="#save_modal"
data-toggle="modal"
>
<i className="fa fa-plus-circle"></i> Save as
</button>
</a>
</div>
);
}