QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-23 10:04:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

change name to Basic instead of Base (#14625)

Browse Source
This commit is contained in:
Hugh A. Miles II
2021-05-13 15:05:37 -04:00
committed by GitHub
parent 1e601483e3
commit 3a81e6aee8
7 changed files with 25 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/db_engine_specs/base_engine_spec_tests.py
View File

@@ -22,7 +22,7 @@ import pytest
from superset.db_engine_specs import get_engine_specs
from superset.db_engine_specs.base import (
BaseEngineSpec,
BaseParametersMixin,
BasicParametersMixin,
builtin_time_grains,
LimitMethod,
)
@@ -383,7 +383,7 @@ def test_validate(is_port_open, is_hostname_valid):
"database": "dbname",
"query": {"sslmode": "verify-full"},
}
errors = BaseParametersMixin.validate_parameters(parameters)
errors = BasicParametersMixin.validate_parameters(parameters)
assert errors == []
@@ -396,7 +396,7 @@ def test_validate_parameters_missing():
"database": "",
"query": {},
}
errors = BaseParametersMixin.validate_parameters(parameters)
errors = BasicParametersMixin.validate_parameters(parameters)
assert errors == [
SupersetError(
message=(
@@ -421,7 +421,7 @@ def test_validate_parameters_invalid_host(is_hostname_valid):
"database": "dbname",
"query": {"sslmode": "verify-full"},
}
errors = BaseParametersMixin.validate_parameters(parameters)
errors = BasicParametersMixin.validate_parameters(parameters)
assert errors == [
SupersetError(
message="One or more parameters are missing: port",
@@ -452,7 +452,7 @@ def test_validate_parameters_port_closed(is_port_open, is_hostname_valid):
"database": "dbname",
"query": {"sslmode": "verify-full"},
}
errors = BaseParametersMixin.validate_parameters(parameters)
errors = BasicParametersMixin.validate_parameters(parameters)
assert errors == [
SupersetError(
message="The port is closed.",