QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Disable cross filtering on charts with no dimensions (#30176)

Browse Source
This commit is contained in:
Kamil Gabryjelski
2024-09-09 12:43:14 +02:00
committed by GitHub
parent 0744abe87b
commit 3aafd29768
9 changed files with 57 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx
View File

@@ -70,6 +70,8 @@ export default function EchartsTimeseries({
setExtraControlHeight(updatedHeight);
}, [formData.showExtraControls]);
const hasDimensions = ensureIsArray(groupby).length > 0;
const getModelInfo = (target: ViewRootGroup, globalModel: GlobalModel) => {
let el = target;
let model: ComponentModel | null = null;
@@ -139,6 +141,9 @@ export default function EchartsTimeseries({
const eventHandlers: EventHandlers = {
click: props => {
if (!hasDimensions) {
return;
}
if (clickTimer.current) {
clearTimeout(clickTimer.current);
}
@@ -215,8 +220,10 @@ export default function EchartsTimeseries({
onContextMenu(pointerEvent.clientX, pointerEvent.clientY, {
drillToDetail: drillToDetailFilters,
crossFilter: getCrossFilterDataMask(seriesName),
drillBy: { filters: drillByFilters, groupbyFieldName: 'groupby' },
crossFilter: hasDimensions
? getCrossFilterDataMask(seriesName)
: undefined,
});
}
},