From 3c5e45e39bb9ee0ddf7d0d588d6965eba0334b2d Mon Sep 17 00:00:00 2001 From: Brian Donovan Date: Wed, 15 Apr 2026 11:28:52 -0700 Subject: [PATCH] fix(chart): improve sort_by_series description wording MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove "secondary" from the description since sort_by_series and sort_by_metric are independent controls — either can be used alone. Clarify that the tiebreaker behavior only applies when both are enabled. Fixes prettier formatting (+ at end of line, not beginning). --- .../plugin-chart-word-cloud/src/plugin/controlPanel.tsx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/superset-frontend/plugins/plugin-chart-word-cloud/src/plugin/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-word-cloud/src/plugin/controlPanel.tsx index 11b3e01cf34..98e5e624b7f 100644 --- a/superset-frontend/plugins/plugin-chart-word-cloud/src/plugin/controlPanel.tsx +++ b/superset-frontend/plugins/plugin-chart-word-cloud/src/plugin/controlPanel.tsx @@ -43,9 +43,10 @@ const config: ControlPanelConfig = { label: t('Sort by series'), default: false, description: t( - 'Include a secondary sort by series name (ascending). ' - + 'This produces consistent ordering when multiple series have the ' - + 'same metric value, but may reduce query performance on some databases.', + 'Sort results by series name in ascending order. ' + + 'When combined with "Sort by metric", this acts as a tiebreaker ' + + 'for equal metric values. Adding this sort may reduce query ' + + 'performance on some databases.', ), }, },