From 3cd67206dfd87c2210a51124f59c00a0019241f3 Mon Sep 17 00:00:00 2001
From: rusackas <evan@rusackas.com>
Date: Tue, 4 Aug 2026 23:25:33 -0700
Subject: [PATCH] fix(mobile): address bito review feedback on mobile PR

- Rename DashboardList's double-negative isNotMobile to isMobile and
  flip its usages for clarity.
- Home.mobile.test.tsx: capture and restore the matchMedia mock in
  afterAll so it doesn't leak past this test file.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 superset-frontend/src/pages/DashboardList/index.tsx   | 8 ++++----
 superset-frontend/src/pages/Home/Home.mobile.test.tsx | 6 +++++-
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/superset-frontend/src/pages/DashboardList/index.tsx b/superset-frontend/src/pages/DashboardList/index.tsx
index 2d63ca1c59a..a5513422098 100644
--- a/superset-frontend/src/pages/DashboardList/index.tsx
+++ b/superset-frontend/src/pages/DashboardList/index.tsx
@@ -179,7 +179,7 @@ const DASHBOARD_COLUMNS_TO_FETCH = [
 
 function DashboardList(props: DashboardListProps) {
   const { addDangerToast, addSuccessToast, user } = props;
-  const isNotMobile = !useIsMobile();
+  const isMobile = useIsMobile();
   const theme = useTheme();
   const [mobileFiltersOpen, setMobileFiltersOpen] = useState(false);
   const { roles } = useSelector<any, UserWithPermissionsAndRoles>(
@@ -859,7 +859,7 @@ function DashboardList(props: DashboardListProps) {
         name={t('Dashboards')}
         buttons={subMenuButtons}
         leftIcon={
-          !isNotMobile ? (
+          isMobile ? (
             <Button
               buttonStyle="link"
               onClick={() => setMobileFiltersOpen(true)}
@@ -967,12 +967,12 @@ function DashboardList(props: DashboardListProps) {
                     ? 'card'
                     : 'table'
                 }
-                forceViewMode={!isNotMobile ? 'card' : undefined}
+                forceViewMode={isMobile ? 'card' : undefined}
                 enableBulkTag={enableBulkTag}
                 bulkTagResourceName="dashboard"
                 mobileFiltersOpen={mobileFiltersOpen}
                 setMobileFiltersOpen={
-                  !isNotMobile ? setMobileFiltersOpen : undefined
+                  isMobile ? setMobileFiltersOpen : undefined
                 }
                 mobileFiltersDrawerTitle={t('Search Dashboards')}
               />
diff --git a/superset-frontend/src/pages/Home/Home.mobile.test.tsx b/superset-frontend/src/pages/Home/Home.mobile.test.tsx
index 268ec48648d..6808b73dd24 100644
--- a/superset-frontend/src/pages/Home/Home.mobile.test.tsx
+++ b/superset-frontend/src/pages/Home/Home.mobile.test.tsx
@@ -39,7 +39,7 @@ jest.mock('@superset-ui/core', () => ({
 }));
 
 // Simulate a mobile viewport for the useIsMobile hook
-mockMobileMatchMedia();
+const restoreMatchMedia = mockMobileMatchMedia();
 
 // API mocks
 const chartsEndpoint = 'glob:*/api/v1/chart/?*';
@@ -128,6 +128,10 @@ afterEach(() => {
   fetchMock.clearHistory();
 });
 
+afterAll(() => {
+  restoreMatchMedia();
+});
+
 test('Mobile view - renders Dashboards panel', async () => {
   await renderWelcome();
   expect(await screen.findByText('Dashboards')).toBeInTheDocument();