mirror of
https://github.com/apache/superset.git
synced 2026-04-18 23:55:00 +00:00
Fixing some warnings during tests (#3648)
* ColorSchemeControl: fixing bad use of PropTypes Accessing PropTypes via the main React package is deprecated, and will be removed in React v16.0. Use the latest available v15.* prop-types package from npm instead. For info on usage, compatibility, migration and more, see https://fb.me/prop-types-docs * Control: adding PropTypes.func in types allowed inside `value` prop This removes a warning during yarn tests Fix #3589 * tests(QueryStateLabel): removing missing prop warning ``` Warning: Failed prop type: The prop `query` is marked as required in `QueryStateLabel`, but its value is `undefined`. in QueryStateLabel ``` * SaveQuery: removing invalid prop `target` supplied to `Overlay`. This removes a warning during yarn tests: ``` Warning: Failed prop type: Invalid prop `target` supplied to `Overlay`. ``` * RunQueryActionButton: removing `isRequired` from queryState props This removes a warning during yarn tests: ``` Warning: Failed prop type: The prop `queryState` is marked as required in `RunQueryActionButton`, but its value is `null`. ```
This commit is contained in:
committed by
Maxime Beauchemin
parent
4a3c09187a
commit
3df3e0d681
@@ -13,11 +13,6 @@ describe('SavedQuery', () => {
|
||||
},
|
||||
};
|
||||
it('is valid', () => {
|
||||
expect(
|
||||
React.isValidElement(<QueryStateLabel />),
|
||||
).to.equal(true);
|
||||
});
|
||||
it('is valid with props', () => {
|
||||
expect(
|
||||
React.isValidElement(<QueryStateLabel {...mockedProps} />),
|
||||
).to.equal(true);
|
||||
|
||||
Reference in New Issue
Block a user