From 3dfa4aa15d720bbcbb4fc7dc6c296c32fe119bbd Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Wed, 8 Jul 2020 17:10:03 -0700 Subject: [PATCH] chore: nixing requiresTime (#10259) --- .../spec/javascripts/explore/controlUtils_spec.jsx | 2 -- .../spec/javascripts/sqllab/ExploreResultsButton_spec.jsx | 2 -- superset-frontend/src/explore/controlPanels/DeckArc.js | 1 - superset-frontend/src/explore/controlPanels/DeckGeojson.js | 1 - superset-frontend/src/explore/controlPanels/DeckGrid.js | 1 - superset-frontend/src/explore/controlPanels/DeckHex.js | 1 - superset-frontend/src/explore/controlPanels/DeckMulti.js | 1 - superset-frontend/src/explore/controlPanels/DeckPath.js | 1 - superset-frontend/src/explore/controlPanels/DeckPolygon.js | 1 - superset-frontend/src/explore/controlPanels/DeckScatter.js | 1 - superset-frontend/src/explore/controlPanels/DeckScreengrid.js | 1 - 11 files changed, 13 deletions(-) diff --git a/superset-frontend/spec/javascripts/explore/controlUtils_spec.jsx b/superset-frontend/spec/javascripts/explore/controlUtils_spec.jsx index 946517d89f9..b01968bf301 100644 --- a/superset-frontend/spec/javascripts/explore/controlUtils_spec.jsx +++ b/superset-frontend/spec/javascripts/explore/controlUtils_spec.jsx @@ -40,7 +40,6 @@ describe('controlUtils', () => { beforeAll(() => { getChartControlPanelRegistry() .registerValue('test-chart', { - requiresTime: true, controlPanelSections: [ { label: t('Chart Options'), @@ -84,7 +83,6 @@ describe('controlUtils', () => { ], }) .registerValue('test-chart-override', { - requiresTime: true, controlPanelSections: [ { label: t('Chart Options'), diff --git a/superset-frontend/spec/javascripts/sqllab/ExploreResultsButton_spec.jsx b/superset-frontend/spec/javascripts/sqllab/ExploreResultsButton_spec.jsx index 82bf912bc56..2685261f528 100644 --- a/superset-frontend/spec/javascripts/sqllab/ExploreResultsButton_spec.jsx +++ b/superset-frontend/spec/javascripts/sqllab/ExploreResultsButton_spec.jsx @@ -65,12 +65,10 @@ describe('ExploreResultsButton', () => { }; const mockChartTypeBarChart = { label: 'Distribution - Bar Chart', - requiresTime: false, value: 'dist_bar', }; const mockChartTypeTB = { label: 'Time Series - Bar Chart', - requiresTime: true, value: 'bar', }; const getExploreResultsButtonWrapper = (props = mockedProps) => diff --git a/superset-frontend/src/explore/controlPanels/DeckArc.js b/superset-frontend/src/explore/controlPanels/DeckArc.js index 5382b2ae0c1..950a9e86522 100644 --- a/superset-frontend/src/explore/controlPanels/DeckArc.js +++ b/superset-frontend/src/explore/controlPanels/DeckArc.js @@ -39,7 +39,6 @@ import { } from './Shared_DeckGL'; export default { - requiresTime: true, controlPanelSections: [ { label: t('Query'), diff --git a/superset-frontend/src/explore/controlPanels/DeckGeojson.js b/superset-frontend/src/explore/controlPanels/DeckGeojson.js index ab7dd6feabf..23590444a70 100644 --- a/superset-frontend/src/explore/controlPanels/DeckGeojson.js +++ b/superset-frontend/src/explore/controlPanels/DeckGeojson.js @@ -39,7 +39,6 @@ import { } from './Shared_DeckGL'; export default { - requiresTime: true, controlPanelSections: [ { label: t('Query'), diff --git a/superset-frontend/src/explore/controlPanels/DeckGrid.js b/superset-frontend/src/explore/controlPanels/DeckGrid.js index 4167b5e3064..598e2207b0e 100644 --- a/superset-frontend/src/explore/controlPanels/DeckGrid.js +++ b/superset-frontend/src/explore/controlPanels/DeckGrid.js @@ -33,7 +33,6 @@ import { } from './Shared_DeckGL'; export default { - requiresTime: true, controlPanelSections: [ { label: t('Query'), diff --git a/superset-frontend/src/explore/controlPanels/DeckHex.js b/superset-frontend/src/explore/controlPanels/DeckHex.js index dbfe6ab1bdd..7c9c874d746 100644 --- a/superset-frontend/src/explore/controlPanels/DeckHex.js +++ b/superset-frontend/src/explore/controlPanels/DeckHex.js @@ -36,7 +36,6 @@ import { } from './Shared_DeckGL'; export default { - requiresTime: true, controlPanelSections: [ { label: t('Query'), diff --git a/superset-frontend/src/explore/controlPanels/DeckMulti.js b/superset-frontend/src/explore/controlPanels/DeckMulti.js index ba693757226..5a15be483d8 100644 --- a/superset-frontend/src/explore/controlPanels/DeckMulti.js +++ b/superset-frontend/src/explore/controlPanels/DeckMulti.js @@ -21,7 +21,6 @@ import { validateNonEmpty } from '@superset-ui/validator'; import { viewport, mapboxStyle } from './Shared_DeckGL'; export default { - requiresTime: true, controlPanelSections: [ { label: t('Map'), diff --git a/superset-frontend/src/explore/controlPanels/DeckPath.js b/superset-frontend/src/explore/controlPanels/DeckPath.js index d9c491673de..8ff3362cdb9 100644 --- a/superset-frontend/src/explore/controlPanels/DeckPath.js +++ b/superset-frontend/src/explore/controlPanels/DeckPath.js @@ -33,7 +33,6 @@ import { } from './Shared_DeckGL'; export default { - requiresTime: true, controlPanelSections: [ { label: t('Query'), diff --git a/superset-frontend/src/explore/controlPanels/DeckPolygon.js b/superset-frontend/src/explore/controlPanels/DeckPolygon.js index 0288f032fa1..b238f490af8 100644 --- a/superset-frontend/src/explore/controlPanels/DeckPolygon.js +++ b/superset-frontend/src/explore/controlPanels/DeckPolygon.js @@ -44,7 +44,6 @@ import { } from './Shared_DeckGL'; export default { - requiresTime: true, controlPanelSections: [ { label: t('Query'), diff --git a/superset-frontend/src/explore/controlPanels/DeckScatter.js b/superset-frontend/src/explore/controlPanels/DeckScatter.js index 7fc407d257e..0adec357c76 100644 --- a/superset-frontend/src/explore/controlPanels/DeckScatter.js +++ b/superset-frontend/src/explore/controlPanels/DeckScatter.js @@ -37,7 +37,6 @@ import { } from './Shared_DeckGL'; export default { - requiresTime: true, onInit: controlState => ({ ...controlState, time_grain_sqla: { diff --git a/superset-frontend/src/explore/controlPanels/DeckScreengrid.js b/superset-frontend/src/explore/controlPanels/DeckScreengrid.js index 8af832c4552..236a85aeb35 100644 --- a/superset-frontend/src/explore/controlPanels/DeckScreengrid.js +++ b/superset-frontend/src/explore/controlPanels/DeckScreengrid.js @@ -33,7 +33,6 @@ import { } from './Shared_DeckGL'; export default { - requiresTime: true, controlPanelSections: [ { label: t('Query'),