QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 03:15:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(types): simplify action types to fix build errors

Browse Source 
The previous BoundActions<CombinedExploreActions> type failed because
action modules export both action creators AND action type constants
(e.g., UPDATE_FORM_DATA_BY_DATASOURCE = 'UPDATE_FORM_DATA_BY_DATASOURCE').

Simplified to Record<string, unknown> which properly represents the
mixed nature of these exports while maintaining type safety elsewhere.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Evan Rusackas
2026-01-19 15:32:25 -08:00
parent c27bf8da53
commit 3fed820f3f
1 changed files with 8 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
superset-frontend/src/explore/components/ExploreViewContainer/index.tsx
View File

@@ -25,7 +25,7 @@ import {
useMemo,
useState,
} from 'react';
import { bindActionCreators, Dispatch, ActionCreatorsMapObject } from 'redux';
import { bindActionCreators, Dispatch } from 'redux';
import { connect } from 'react-redux';
import {
useChangeEffect,
@@ -73,7 +73,6 @@ import { datasourcesActions } from 'src/explore/actions/datasourcesActions';
import { mountExploreUrl } from 'src/explore/exploreUtils';
import { getFormDataFromControls } from 'src/explore/controlUtils';
import * as exploreActions from 'src/explore/actions/exploreActions';
import { ExploreActions } from 'src/explore/actions/exploreActions';
import * as saveModalActions from 'src/explore/actions/saveModalActions';
import { useTabId } from 'src/hooks/useTabId';
import withToasts from 'src/components/MessageToasts/withToasts';
@@ -357,22 +356,11 @@ interface StateProps {
isSaveModalVisible: boolean;
}
// Combined actions type representing all action creators used in Explore
type CombinedExploreActions = typeof exploreActions &
typeof datasourcesActions &
typeof saveModalActions &
typeof chartActions &
typeof logActions;
// Bound action creators type (what mapDispatchToProps actually returns)
type BoundActions<T extends ActionCreatorsMapObject> = {
[K in keyof T]: T[K] extends (...args: infer A) => infer R
? (...args: A) => R extends (...args: unknown[]) => infer R2 ? R2 : R
: T[K];
};
// Combined actions from all action modules used in Explore
// Note: These modules export both action creators AND action type constants,
// so we use Record<string, unknown> to accommodate the mixed exports
interface DispatchProps {
actions: BoundActions<CombinedExploreActions>;
actions: Record<string, unknown>;
}
type ExploreViewContainerProps = StateProps & DispatchProps & OwnProps;
@@ -1205,7 +1193,7 @@ function mapStateToProps(state: ExploreRootState) {
}
function mapDispatchToProps(dispatch: Dispatch): DispatchProps {
const actions: CombinedExploreActions = {
const actions = {
...exploreActions,
...datasourcesActions,
...saveModalActions,
@@ -1213,10 +1201,8 @@ function mapDispatchToProps(dispatch: Dispatch): DispatchProps {
...logActions,
};
return {
actions: bindActionCreators(
actions as ActionCreatorsMapObject,
dispatch,
) as BoundActions<CombinedExploreActions>,
// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Action modules export mixed types (creators + constants)
actions: bindActionCreators(actions as any, dispatch),
};
}