QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-07 18:35:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: use sqlglot to validate adhoc subquery (#33560)

Browse Source
This commit is contained in:
Beto Dealmeida
2025-05-30 18:09:19 -04:00
committed by GitHub
parent cf315388f2
commit 401ce56fa1
10 changed files with 123 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/unit_tests/sql_lab_test.py
View File

@@ -232,7 +232,6 @@ def test_apply_rls(mocker: MockerFixture) -> None:
database.get_default_schema_for_query.return_value = "public"
database.get_default_catalog.return_value = "examples"
database.db_engine_spec = PostgresEngineSpec
query = mocker.MagicMock(database=database, catalog="examples")
get_predicates_for_table = mocker.patch(
"superset.sql_lab.get_predicates_for_table",
side_effect=[["c1 = 1"], ["c2 = 2"]],
@@ -241,12 +240,12 @@ def test_apply_rls(mocker: MockerFixture) -> None:
parsed_statement = SQLStatement("SELECT * FROM t1, t2", "postgresql")
parsed_statement.tables = sorted(parsed_statement.tables, key=lambda x: x.table) # type: ignore
apply_rls(query, parsed_statement)
apply_rls(database, "examples", "public", parsed_statement)
get_predicates_for_table.assert_has_calls(
[
mocker.call(Table("t1", "public", "examples"), database, True),
mocker.call(Table("t2", "public", "examples"), database, True),
mocker.call(Table("t1", "public", "examples"), database, "examples"),
mocker.call(Table("t2", "public", "examples"), database, "examples"),
]
)
@@ -285,4 +284,4 @@ def test_get_predicates_for_table(mocker: MockerFixture) -> None:
db.session.query().filter().one_or_none.return_value = dataset
table = Table("t1", "public", "examples")
assert get_predicates_for_table(table, database, True) == ["c1 = 1"]
assert get_predicates_for_table(table, database, "examples") == ["c1 = 1"]