QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Feature] Dashboard filter indicators (#7908)

Browse Source 
* dashboard filter indicators

* add/fix unit tests
This commit is contained in:
Grace Guo
2019-08-21 17:34:08 -07:00
committed by GitHub
parent 0fd7364503
commit 40776bd547
74 changed files with 2455 additions and 454 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
superset/assets/spec/javascripts/dashboard/actions/dashboardState_spec.js
View File

@@ -19,17 +19,29 @@
import sinon from 'sinon';
import { SupersetClient } from '@superset-ui/connection';
import { saveDashboardRequest } from '../../../../src/dashboard/actions/dashboardState';
import {
removeSliceFromDashboard,
saveDashboardRequest,
} from '../../../../src/dashboard/actions/dashboardState';
import { REMOVE_FILTER } from '../../../../src/dashboard/actions/dashboardFilters';
import { UPDATE_COMPONENTS_PARENTS_LIST } from '../../../../src/dashboard/actions/dashboardLayout';
import {
filterId,
sliceEntitiesForDashboard as sliceEntities,
} from '../fixtures/mockSliceEntities';
import { emptyFilters } from '../fixtures/mockDashboardFilters';
import mockDashboardData from '../fixtures/mockDashboardData';
import { DASHBOARD_GRID_ID } from '../../../../src/dashboard/util/constants';
describe('dashboardState actions', () => {
const mockState = {
dashboardState: {
sliceIds: [filterId],
hasUnsavedChanges: true,
},
dashboardInfo: {},
sliceEntities,
dashboardFilters: emptyFilters,
dashboardLayout: {
past: [],
present: mockDashboardData.positions,
@@ -97,4 +109,14 @@ describe('dashboardState actions', () => {
);
});
});
it('should dispatch removeFilter if a removed slice is a filter_box', () => {
const { getState, dispatch } = setup(mockState);
const thunk = removeSliceFromDashboard(filterId);
thunk(dispatch, getState);
const removeFilter = dispatch.getCall(0).args[0];
removeFilter(dispatch, getState);
expect(dispatch.getCall(3).args[0].type).toBe(REMOVE_FILTER);
});
});