QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Feature] Dashboard filter indicators (#7908)

Browse Source 
* dashboard filter indicators

* add/fix unit tests
This commit is contained in:
Grace Guo
2019-08-21 17:34:08 -07:00
committed by GitHub
parent 0fd7364503
commit 40776bd547
74 changed files with 2455 additions and 454 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
superset/assets/spec/javascripts/dashboard/util/findTabIndexByComponentId_spec.js
View File

@@ -49,22 +49,22 @@ describe('findTabIndexByComponentId', () => {
];
const badPath = ['ROOT_ID', 'TABS-MNQQSW-kyd', 'TAB-ABC', 'TABS-Oduxop1L7I'];
it('should return 0 if no directPathToChild', () => {
it('should return -1 if no directPathToChild', () => {
expect(
findTabIndexByComponentId({
currentComponent: topLevelTabsComponent,
directPathToChild: [],
}),
).toBe(0);
).toBe(-1);
});
it('should return 0 if not found tab id', () => {
it('should return -1 if not found tab id', () => {
expect(
findTabIndexByComponentId({
currentComponent: topLevelTabsComponent,
directPathToChild: badPath,
}),
).toBe(0);
).toBe(-1);
});
it('should return children index if matched an id in the path', () => {

8
superset/assets/spec/javascripts/dashboard/util/getFormDataWithExtraFilters_spec.js
View File

@@ -34,8 +34,8 @@ describe('getFormDataWithExtraFilters', () => {
},
},
dashboardMetadata: {
filter_immune_slices: [],
filter_immune_slice_fields: {},
filterImmuneSlices: [],
filterImmuneSliceFields: {},
},
filters: {
filterId: {
@@ -65,7 +65,7 @@ describe('getFormDataWithExtraFilters', () => {
const result = getFormDataWithExtraFilters({
...mockArgs,
dashboardMetadata: {
filter_immune_slices: [chartId],
filterImmuneSlices: [chartId],
},
});
expect(result.extra_filters).toHaveLength(0);
@@ -75,7 +75,7 @@ describe('getFormDataWithExtraFilters', () => {
const result = getFormDataWithExtraFilters({
...mockArgs,
dashboardMetadata: {
filter_immune_slice_fields: {
filterImmuneSliceFields: {
[chartId]: ['region'],
},
},

37
superset/assets/spec/javascripts/dashboard/util/getLeafComponentIdFromPath_spec.js Normal file
View File

@@ -0,0 +1,37 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import getLeafComponentIdFromPath from '../../../../src/dashboard/util/getLeafComponentIdFromPath';
import { filterId } from '../fixtures/mockSliceEntities';
import { dashboardFilters } from '../fixtures/mockDashboardFilters';
describe('getLeafComponentIdFromPath', () => {
const path = dashboardFilters[filterId].directPathToFilter;
const leaf = path.slice().pop();
it('should return component id', () => {
expect(getLeafComponentIdFromPath(path)).toBe(leaf);
});
it('should not return label component', () => {
const updatedPath = dashboardFilters[filterId].directPathToFilter.concat(
'LABEL-test123',
);
expect(getLeafComponentIdFromPath(updatedPath)).toBe(leaf);
});
});