QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-23 01:55:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: subheader should show as subtitle (#33172)

Browse Source
This commit is contained in:
Elizabeth Thompson
2025-04-17 22:03:20 -07:00
committed by GitHub
parent 00f1fdb3c4
commit 4140261797
7 changed files with 327 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/transformProps.ts
View File

@@ -47,19 +47,22 @@ export default function transformProps(
const {
headerFontSize,
metric = 'value',
subtitle = '',
subtitle,
subtitleFontSize,
forceTimestampFormatting,
timeFormat,
yAxisFormat,
conditionalFormatting,
currencyFormat,
subheader,
subheaderFontSize,
} = formData;
const refs: Refs = {};
const { data = [], coltypes = [] } = queriesData[0];
const granularity = extractTimegrain(rawFormData as QueryFormData);
const metricName = getMetricLabel(metric);
const formattedSubtitle = subtitle;
const formattedSubtitle = subtitle || subheader || '';
const formattedSubtitleFontSize = subheaderFontSize || subtitleFontSize;
const bigNumber =
data.length === 0 ? null : parseMetricValue(data[0][metricName]);
@@ -105,10 +108,8 @@ export default function transformProps(
bigNumber,
headerFormatter,
headerFontSize,
subtitleFontSize,
subtitleFontSize: formattedSubtitleFontSize,
subtitle: formattedSubtitle,
subheader: '',
subheaderFontSize: subtitleFontSize,
onContextMenu,
refs,
colorThresholdFormatters,