[explore-v2] control panel fixes (#1529)

* make fieldset conditions more clear

* make label required

* use render* pattern

* use slugify util for turning labels into ids

* use field rather than html

* don't need panel-title class here
This commit is contained in:
Alanna Scott
2016-11-02 21:51:56 -07:00
committed by GitHub
parent ae46561648
commit 4156ad5a30
6 changed files with 32 additions and 18 deletions

View File

@@ -16,12 +16,12 @@ const defaultProps = {
};
export default class ControlPanelSection extends React.Component {
header() {
renderHeader() {
const { label, tooltip } = this.props;
let header;
if (label) {
header = (
<div className="panel-title">
<div>
{label} &nbsp;
{tooltip && <InfoTooltipWithTrigger label={label} tooltip={tooltip} />}
</div>
@@ -32,7 +32,7 @@ export default class ControlPanelSection extends React.Component {
render() {
return (
<Panel header={this.header()}>
<Panel header={this.renderHeader()}>
{this.props.children}
</Panel>
);