[explore-v2] control panel fixes (#1529)

* make fieldset conditions more clear

* make label required

* use render* pattern

* use slugify util for turning labels into ids

* use field rather than html

* don't need panel-title class here
This commit is contained in:
Alanna Scott
2016-11-02 21:51:56 -07:00
committed by GitHub
parent ae46561648
commit 4156ad5a30
6 changed files with 32 additions and 18 deletions

View File

@@ -1,6 +1,7 @@
import React, { PropTypes } from 'react';
import { FormGroup, FormControl } from 'react-bootstrap';
import ControlLabelWithTooltip from './ControlLabelWithTooltip';
import { slugify } from '../../modules/utils';
const propTypes = {
label: PropTypes.string,
@@ -14,7 +15,7 @@ const defaultProps = {
export default function SelectField({ label, description }) {
return (
<FormGroup controlId={`formControlsSelect-${label}`}>
<FormGroup controlId={`formControlsSelect-${slugify(label)}`}>
<ControlLabelWithTooltip label={label} description={description} />
<FormControl componentClass="select" placeholder="select">
<option value="select">select</option>