test: SelectAsyncControl (#13638)

* SelectAsyncControl tests

* fix: lint error

* applying factory to  props
This commit is contained in:
Bruno Motta
2021-03-26 02:07:05 -03:00
committed by GitHub
parent 2aedaaa03e
commit 416f188328
2 changed files with 116 additions and 4 deletions

View File

@@ -0,0 +1,112 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import userEvent from '@testing-library/user-event';
import React from 'react';
import { render, screen } from 'spec/helpers/testing-library';
import SelectAsyncControl from '.';
jest.mock('src/components/AsyncSelect', () => ({
__esModule: true,
default: (props: any) => (
<div
data-test="select-test"
data-data-endpoint={props.dataEndpoint}
data-value={JSON.stringify(props.value)}
data-placeholder={props.placeholder}
data-multi={props.multi ? 'true' : 'false'}
>
<button
type="button"
onClick={() => props.onChange(props.multi ? [] : {})}
>
onChange
</button>
<button type="button" onClick={() => props.mutator()}>
mutator
</button>
<div data-test="valueRenderer">
{props.valueRenderer({ label: 'valueRenderer' })}
</div>
</div>
),
}));
const createProps = () => ({
value: [],
dataEndpoint: 'api/v1/dataset/related/owners',
multi: true,
onAsyncErrorMessage: 'Error while fetching data',
placeholder: 'Select ...',
onChange: jest.fn(),
mutator: jest.fn(),
});
beforeEach(() => {
jest.resetAllMocks();
});
test('Should render', () => {
const props = createProps();
render(<SelectAsyncControl {...props} />, { useRedux: true });
expect(screen.getByTestId('SelectAsyncControl')).toBeInTheDocument();
});
test('Should send correct props to AsyncSelect component - value props', () => {
const props = createProps();
render(<SelectAsyncControl {...props} />, { useRedux: true });
expect(screen.getByTestId('select-test')).toHaveAttribute(
'data-data-endpoint',
props.dataEndpoint,
);
expect(screen.getByTestId('select-test')).toHaveAttribute(
'data-value',
JSON.stringify(props.value),
);
expect(screen.getByTestId('select-test')).toHaveAttribute(
'data-placeholder',
props.placeholder,
);
expect(screen.getByTestId('select-test')).toHaveAttribute(
'data-multi',
'true',
);
expect(screen.getByTestId('valueRenderer')).toHaveTextContent(
'valueRenderer',
);
});
test('Should send correct props to AsyncSelect component - function onChange multi:true', () => {
const props = createProps();
render(<SelectAsyncControl {...props} />, { useRedux: true });
expect(props.onChange).toBeCalledTimes(0);
userEvent.click(screen.getByText('onChange'));
expect(props.onChange).toBeCalledTimes(1);
});
test('Should send correct props to AsyncSelect component - function onChange multi:false', () => {
const props = createProps();
render(<SelectAsyncControl {...{ ...props, multi: false }} />, {
useRedux: true,
});
expect(props.onChange).toBeCalledTimes(0);
userEvent.click(screen.getByText('onChange'));
expect(props.onChange).toBeCalledTimes(1);
});

View File

@@ -0,0 +1,92 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import PropTypes from 'prop-types';
import { t } from '@superset-ui/core';
import Select from 'src/components/AsyncSelect';
import ControlHeader from 'src/explore/components/ControlHeader';
import withToasts from 'src/messageToasts/enhancers/withToasts';
const propTypes = {
dataEndpoint: PropTypes.string.isRequired,
multi: PropTypes.bool,
mutator: PropTypes.func,
onAsyncErrorMessage: PropTypes.string,
onChange: PropTypes.func,
placeholder: PropTypes.string,
value: PropTypes.oneOfType([
PropTypes.string,
PropTypes.number,
PropTypes.arrayOf(PropTypes.string),
PropTypes.arrayOf(PropTypes.number),
]),
addDangerToast: PropTypes.func.isRequired,
};
const defaultProps = {
multi: true,
onAsyncErrorMessage: t('Error while fetching data'),
onChange: () => {},
placeholder: t('Select ...'),
};
const SelectAsyncControl = props => {
const {
value,
onChange,
dataEndpoint,
multi,
mutator,
placeholder,
onAsyncErrorMessage,
} = props;
const onSelectionChange = options => {
let val;
if (multi) {
val = options?.map(option => option.value) ?? null;
} else {
val = options?.value ?? null;
}
onChange(val);
};
return (
<div data-test="SelectAsyncControl">
<ControlHeader {...props} />
<Select
dataEndpoint={dataEndpoint}
onChange={onSelectionChange}
onAsyncError={errorMsg =>
props.addDangerToast(`${onAsyncErrorMessage}: ${errorMsg}`)
}
mutator={mutator}
multi={multi}
value={value}
placeholder={placeholder}
valueRenderer={v => <div>{v.label}</div>}
/>
</div>
);
};
SelectAsyncControl.propTypes = propTypes;
SelectAsyncControl.defaultProps = defaultProps;
export default withToasts(SelectAsyncControl);